feat: upgrade roslyn 4.0 to 4.1 by TimothyMakkison · Pull Request #1828 · reactiveui/refit
Upgrade Roslyn 4.0 to Roslyn 4.1 for access to WithTrackingName
- bit concerned with line 29 in
refit.props - Looks like the tests are failing because it can't find the old Roslyn 4.0 csproj
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 83.74%. Comparing base (
6ebeda5) to head (2996d20).
Report is 96 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1828 +/- ## ========================================== - Coverage 87.73% 83.74% -3.99% ========================================== Files 33 36 +3 Lines 2348 2449 +101 Branches 294 345 +51 ========================================== - Hits 2060 2051 -9 - Misses 208 316 +108 - Partials 80 82 +2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
@TimothyMakkison all building now
Thanks for fixing that, annoyed I missed the obvious reference 😅
Close to adding incremental generation, I'm currently breaking it up into smaller PRs to make it easier to review if thats okay with you.
It's worked well until now, so let's go with the incremental changes though multiple PR's, it also makes undoing anything untoward easier.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters