feat: add URL fragment tests by TimothyMakkison · Pull Request #1900 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TimothyMakkison

Copy link Copy Markdown

Contributor

@TimothyMakkison TimothyMakkison commented

Nov 1, 2024

edited

Loading

  • Added fragment tests, ensuring that the fragment is always removed. ie /foo#name -> /foo
  • Updated InvalidParamSubstitutionShouldThrow
  • Added InvalidFragmentParamSubstitutionShouldThrow

This is to prevent future changes to Uri from breaking things. I'm looking at removing Uri and UriBuilder creation in RequestBuilderImplementation.
Out of curiosity why doesn't refit support fragments, is this intentional or an oversight?

@codecov

Copy link Copy Markdown

codecov bot commented

Nov 1, 2024

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (6ebeda5) to head (98cc73d).
Report is 157 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1900      +/-   ##
==========================================
- Coverage   87.73%   84.89%   -2.85%     
==========================================
  Files          33       36       +3     
  Lines        2348     2502     +154     
  Branches      294      361      +67     
==========================================
+ Hits         2060     2124      +64     
- Misses        208      299      +91     
+ Partials       80       79       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TimothyMakkison TimothyMakkison changed the title Fragment tests feat: add URL fragment tests

Nov 1, 2024

@ChrisPulman ChrisPulman merged commit e13386f into reactiveui:main

Nov 3, 2024

@github-actions

Copy link Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Nov 18, 2024

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @ChrisPulman