feat: add URL fragment tests by TimothyMakkison · Pull Request #1900 · reactiveui/refit
Navigation Menu
{{ message }}
reactiveui / refit Public
- Notifications You must be signed in to change notification settings
- Fork 783
Merged
ChrisPulman merged 2 commits intoreactiveui:mainfrom
Nov 3, 2024Merged
feat: add URL fragment tests#1900
ChrisPulman merged 2 commits intoreactiveui:mainfrom
feat: add URL fragment tests#1900
ChrisPulman merged 2 commits intoreactiveui:mainfrom
Conversation
Copy link Copy Markdown
Contributor
- Added fragment tests, ensuring that the fragment is always removed. ie
/foo#name->/foo - Updated
InvalidParamSubstitutionShouldThrow - Added
InvalidFragmentParamSubstitutionShouldThrow
This is to prevent future changes to Uri from breaking things. I'm looking at removing Uri and UriBuilder creation in RequestBuilderImplementation.
Out of curiosity why doesn't refit support fragments, is this intentional or an oversight?
Copy link Copy Markdown
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 84.89%. Comparing base (
6ebeda5) to head (98cc73d).
Report is 157 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1900 +/- ## ========================================== - Coverage 87.73% 84.89% -2.85% ========================================== Files 33 36 +3 Lines 2348 2502 +154 Branches 294 361 +67 ========================================== + Hits 2060 2124 +64 - Misses 208 299 +91 + Partials 80 79 -1
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
TimothyMakkison
changed the title
Fragment tests
feat: add URL fragment tests
TimothyMakkison
force-pushed
the
fragment_tests
branch
from
111ae8f to
6630664
Compare
TimothyMakkison
force-pushed
the
fragment_tests
branch
from
6630664 to
98cc73d
Compare
ChrisPulman approved these changes Nov 3, 2024
ChrisPulman
merged commit
e13386f
into
reactiveui:main
Copy link Copy Markdown
github-actions
bot
commented
Nov 18, 2024
github-actions bot commented
Nov 18, 2024This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.