fix: replace `Append` with `WriteLine` and remove blank spaces by TimothyMakkison · Pull Request #1967 · reactiveui/refit
Navigation Menu
{{ message }}
reactiveui / refit Public
- Notifications You must be signed in to change notification settings
- Fork 783
Merged
ChrisPulman merged 1 commit intoreactiveui:mainfrom
Apr 5, 2025Merged
fix: replace Append with WriteLine and remove blank spaces#1967
ChrisPulman merged 1 commit intoreactiveui:mainfrom
fix: replace Append with WriteLine and remove blank spaces#1967
ChrisPulman merged 1 commit intoreactiveui:mainfrom
Conversation
Copy link Copy Markdown
Contributor
- Update
Emitterlogic - Remove blank line before the classes body
- tab align generic contraints
- Cleaned up code with csharpier
Should I remove the other random empty lines? ie
- The gap after the constructor
- Between
partial class Generatedand/// <inheritdoc /> - Between the namespace declartation and the partial class declaration
- Consider using a file scoped namespace to reduce nesting
TimothyMakkison
force-pushed
the
source_writer_2
branch
2 times, most recently
from
f9e4fcf to
cfdddeb
Compare
TimothyMakkison
marked this pull request as ready for review
TimothyMakkison
force-pushed
the
source_writer_2
branch
2 times, most recently
from
cf7832b to
74b5c74
Compare
TimothyMakkison
force-pushed
the
source_writer_2
branch
from
74b5c74 to
7758e56
Compare
Copy link Copy Markdown
Codecov Report
All modified and coverable lines are covered by tests ✅
Project coverage is 85.51%. Comparing base (
6ebeda5) to head (7758e56).
Report is 180 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@ ## main #1967 +/- ## ========================================== - Coverage 87.73% 85.51% -2.22% ========================================== Files 33 36 +3 Lines 2348 2506 +158 Branches 294 365 +71 ========================================== + Hits 2060 2143 +83 - Misses 208 285 +77 + Partials 80 78 -2
☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.
🚀 New features to boost your workflow:
- ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
ChrisPulman approved these changes Apr 5, 2025
TimothyMakkison
mentioned this pull request
Copy link Copy Markdown
github-actions
bot
commented
Apr 20, 2025
github-actions bot commented
Apr 20, 2025This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
github-actions
bot
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.