fix: replace `Append` with `WriteLine` and remove blank spaces by TimothyMakkison · Pull Request #1967 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TimothyMakkison

Copy link Copy Markdown

Contributor

@TimothyMakkison TimothyMakkison commented

Apr 4, 2025

edited

Loading

  • Update Emitter logic
  • Remove blank line before the classes body
  • tab align generic contraints
  • Cleaned up code with csharpier

Should I remove the other random empty lines? ie

  • The gap after the constructor
  • Between partial class Generated and /// <inheritdoc />
  • Between the namespace declartation and the partial class declaration
  • Consider using a file scoped namespace to reduce nesting

@TimothyMakkison TimothyMakkison force-pushed the source_writer_2 branch 2 times, most recently from f9e4fcf to cfdddeb Compare

April 4, 2025 21:52

@TimothyMakkison TimothyMakkison marked this pull request as ready for review

April 4, 2025 21:55

@TimothyMakkison TimothyMakkison force-pushed the source_writer_2 branch 2 times, most recently from cf7832b to 74b5c74 Compare

April 4, 2025 22:26

@codecov

Copy link Copy Markdown

codecov bot commented

Apr 4, 2025

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (6ebeda5) to head (7758e56).
Report is 180 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1967      +/-   ##
==========================================
- Coverage   87.73%   85.51%   -2.22%     
==========================================
  Files          33       36       +3     
  Lines        2348     2506     +158     
  Branches      294      365      +71     
==========================================
+ Hits         2060     2143      +83     
- Misses        208      285      +77     
+ Partials       80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisPulman ChrisPulman merged commit 2d13fff into reactiveui:main

Apr 5, 2025

2 of 3 checks passed

@github-actions

Copy link Copy Markdown

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

Apr 20, 2025

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @ChrisPulman