feat: add verify snapshot testing for `InterfaceStubGeneratorTests` by TimothyMakkison · Pull Request #1976 · reactiveui/refit

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@TimothyMakkison

Copy link Copy Markdown

Contributor

@TimothyMakkison TimothyMakkison commented

Apr 20, 2025

edited

Loading

  • Added verify snapshot testing to Reft.Tests.InterfaceStubGeneratorTests
  • Removed unused usings
  • The ApiApprovalTest kept failing unless I added new snapshots. I'm not sure why, is this a problem?

Related #1964

@TimothyMakkison TimothyMakkison marked this pull request as ready for review

April 20, 2025 19:06

@TimothyMakkison TimothyMakkison force-pushed the snapshot_tes_stub_gen_tests branch 2 times, most recently from 1403de1 to c74a1e4 Compare

April 22, 2025 18:46

@TimothyMakkison TimothyMakkison force-pushed the snapshot_tes_stub_gen_tests branch from c74a1e4 to dc531fc Compare

April 22, 2025 20:46

@codecov

Copy link Copy Markdown

codecov bot commented

Apr 22, 2025

edited

Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.51%. Comparing base (6ebeda5) to head (dc531fc).
Report is 183 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1976      +/-   ##
==========================================
- Coverage   87.73%   85.51%   -2.22%     
==========================================
  Files          33       36       +3     
  Lines        2348     2506     +158     
  Branches      294      365      +71     
==========================================
+ Hits         2060     2143      +83     
- Misses        208      285      +77     
+ Partials       80       78       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ChrisPulman ChrisPulman merged commit 61f2973 into reactiveui:main

Apr 23, 2025

2 of 3 checks passed

@github-actions

Copy link Copy Markdown

github-actions bot commented

May 8, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators

May 8, 2025

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ChrisPulman ChrisPulman ChrisPulman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TimothyMakkison @ChrisPulman