Thinking-in-react-till-3rd-step by nafistiham · Pull Request #8 · reactjs/bn.react.dev
Navigation Menu
{{ message }}
reactjs / bn.react.dev Public
- Notifications You must be signed in to change notification settings
- Fork 65
Merged
nafistiham merged 9 commits intoreactjs:mainfrom
May 4, 2023Merged
Thinking-in-react-till-3rd-step#8
nafistiham merged 9 commits intoreactjs:mainfrom
Thinking-in-react-till-3rd-step#8
nafistiham merged 9 commits intoreactjs:mainfrom
Conversation
Copy link
Collaborator
nafistiham
commented
May 1, 2023
nafistiham
commented
This is WIP. Creating a PR for simultaneous review. Please don't merge it before the whole page is done.
Copy link
Size changes
Details
📦 Next.js Bundle Analysis for react-dev
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
Copy link
Collaborator
moshfiqrony
commented
May 1, 2023
moshfiqrony commented
May 1, 2023@nafistiham bhai make it draft from the next time. Then no one will be able to merge it but will be able to give review.
moshfiqrony
mentioned this pull request
nafistiham
marked this pull request as draft
Copy link
Collaborator Author
nafistiham
commented
May 1, 2023
nafistiham commented
May 1, 2023@nafistiham bhai make it draft from the next time. Then no one will be able to merge it but will be able to give review.
Thanks. Turned it into a draft.
nafistiham
marked this pull request as ready for review
nafistiham
requested review from
ahnafyy and
moshfiqrony
nafistiham
changed the title
WIP-thinking-in-react
Thinking-in-react-till-3rd-step
MahdiMurshed reviewed May 3, 2023
src/content/learn/thinking-in-react.md
Outdated
Show resolved
Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md
Outdated
Show resolved
Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md
Outdated
Show resolved
Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md
Outdated
Show resolved
Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
src/content/learn/thinking-in-react.md
Show resolved
Hide resolved
src/content/learn/thinking-in-react.md Show resolved Hide resolved
nafistiham
requested review from
MahdiMurshed and
nomandhoni-cs
nomandhoni-cs approved these changes May 4, 2023
Copy link
Collaborator
nomandhoni-cs
left a comment
nomandhoni-cs
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nafistiham Bhai, Thanks again for an amazing translation. 👏
I added an word, I guess you missed that. I am approving this PR.
src/content/learn/thinking-in-react.md
Outdated
Show resolved
Hide resolved
src/content/learn/thinking-in-react.md Outdated Show resolved Hide resolved
MahdiMurshed approved these changes May 4, 2023
nafistiham
added this pull request to the merge queue
Merged
via the queue into
reactjs:main
with commit 29b59e5
nafistiham
deleted the
thinking-in-react
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants