Translated your first component by Akshit1025 · Pull Request #204 · reactjs/hi.react.dev
I have translated the Your First Component page. Please review it
Sections on the page
Intro
Components: UI Building Blocks
Defining a Component
- Step 1: Export the component
- Step 2: Define the function
- Step 3: Add Markup
Using a component
- What the browser sees
- Nesting and Organising Components
Recap
Challenge
- Export the Component
- Fix the return statement
- Spot the Mistake
- Your Own Component
Please let me know if there are any changes that have to be made
Please checkmark these boxes too
Thank You
@arshadkazmi42 please review this pull request
Thank You
@Akshit1025 I have been a bit busy. I will get to it soon. Sorry about the delay
@arshadkazmi42 please review this pull request
Thank You@Akshit1025 I have been a bit busy. I will get to it soon. Sorry about the delay
ok no problem
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this.
I have added few comments till line 55
Lets' get these fixed and then I will continue with further review.
You can check for our review guidelines at #23
@arshadkazmi42 Hey, I have changed all the typos that you have suggested till now. You can start reviewing further
Thanks
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added more review comments till line 170.
Let's get these fixed, post that we can continue further with the review
@arshadkazmi42 I have fixed the typos and now you can further review the translation
@Akshit1025 There are two review comments which still have minor issues. Rest looks fine.
I have marked them as unresolved, can you check and update those? Post that we can continue further.
@Akshit1025 There is still one typo in the code block. Please check the unresolved comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added review in rest of the file.
Once these are fixed we can get this merged.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added review in rest of the file.
Once these are fixed we can get this merged.
@arshadkazmi42 all the typos that you have suggested have been completed
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. Thank you for working on all the fixes.
lets get this merged 🎉
Akshit1025
deleted the
translated-your-first-component
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters