translation of choosing-the-state-structure page in Hindi by BrijenMakwana ยท Pull Request #221 ยท reactjs/hi.react.dev
Translation of choosing-the-state-structure page in Hindi
Review Progress:
- Overview
- Principles for structuring state
- Group related state
- Avoid contradictions in state
- Avoid redundant state
- Avoid duplication in state
- Avoid deeply nested state
- Recap
- Challenges
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this up.
I have added review till line 102.
Lets get these fixed and post that we can continue with the review.
To know more about our review guides lines refer #23
Thank you for taking this up.
I have added review till line 102.
Lets get these fixed and post that we can continue with the review. To know more about our review guides lines refer #23
I have made the changes that you have asked ๐๐ป
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added some more reviews till line 375.
Let's get these fixed and post that we can continue further with the review.
Thank you for working on the fixes.
I have added some more reviews till line 375.
Let's get these fixed and post that we can continue further with the review.
I have made the changes ๐๐ป
Thank you for working on the fixes.
I have added some more reviews till line 375.
Let's get these fixed and post that we can continue further with the review.
@arshadkazmi42 Changes have been made, it's a request to provide a review ๐
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added more reviews till line 818.
Lets get these fixed and then we can continue further.
@arshadkazmi42 My pull request is open for almost 3 months now. It's a request to provide a review soon so it can be merged.
@BrijenMakwana Thank you for the reminder and your patience. I am a bit busy and will be going through it soon.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on the fixes.
I have added review to rest of the file, once these are fixed we can get this merged
Thank you @BrijenMakwana for working on this. There seems to be a conflict. Can you fix those conflicts? post that we can get this merged.
@BrijenMakwana I see a lot of changes which are not related to this PR in the last commit. Can you revert the last commit and resolve the conflicts only from this file src/content/learn/choosing-the-state-structure.md
Let me know if you need any help with it.
@BrijenMakwana I see a lot of changes which are not related to this PR in the last commit. Can you revert the last commit and resolve the conflicts only from this file
src/content/learn/choosing-the-state-structure.mdLet me know if you need any help with it.
Sure. I'm working on it. Will let you know
Brijen Makwana and others added 5 commits
May 28, 2023 16:15Size changes
Details
๐ฆ Next.js Bundle Analysis for react-dev
This analysis was generated by the Next.js Bundle Analysis action. ๐ค
This PR introduced no changes to the JavaScript bundle! ๐
Thank you @BrijenMakwana for working on this and thank you for your patience working on all the fixes.
Thank you @BrijenMakwana for working on this and thank you for your patience working on all the fixes.
Thank you very much. I enjoyed working on it ๐
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters