Translating Components and Props page by helios1101 · Pull Request #24

Translating Components and Props page by helios1101 · Pull Request #24 · reactjs/hi.react.dev

helios1101 changed the title ~~Adding Components and Props page~~ Translating Components and Props page

Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start.
I have left a few feedbacks.
Also do have a read of our review process at #23

I have done the review till line 90, once these are fixed, we will continue the review of next parts

@helios1101 Also in PR description can you add list of all headings similar to how you have added page name

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work.
Added few more and which I missed initially.
and you have missed 1 fix.
Once these are done, we will continue with next parts of review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work.
I have added some more feedbacks for rest of the file.

		```

		Such functions are called ["pure"](https://en.wikipedia.org/wiki/Pure_function) because they do not attempt to change their inputs, and always return the same result for the same inputs.
		यह फंक्शन्स को हम कहते है ["pure"](https://en.wikipedia.org/wiki/Pure_function) क्योंकि वे अपने इनपुट को बदलने का प्रयास नहीं करते हैं, और हमेशा समान इनपुट के लिए समान परिणाम लौटाते हैं\|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

यह => ऐसे

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed this one

यह => ऐसे

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome.
I missed a couple of things in previous review, my bad.
I have pointed those out, once you are done with those changes, it will be done from my end and we can move on to second phase of the review

		```

		Such functions are called ["pure"](https://en.wikipedia.org/wiki/Pure_function) because they do not attempt to change their inputs, and always return the same result for the same inputs.
		यह फंक्शन्स को हम कहते है ["pure"](https://en.wikipedia.org/wiki/Pure_function) क्योंकि वे अपने इनपुट को बदलने का प्रयास नहीं करते हैं, और हमेशा समान इनपुट के लिए समान परिणाम लौटाते हैं\|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed this one

यह => ऐसे

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Thank you for working on this and fixing all the review feedback.
Review is done from me.
For second review @saranshkataria can you have a look at this for the second review

		इस `Avatar` को जानने की जरूरत नहीं है कि यह एक `Comment` के अंदर रेंडर किया जा रहा है\| इसलिए हमने इसके prop को एक ज्यादा सामान्य नाम दिया है : `author` के बजाय `user`\|

		We recommend naming props from the component's own point of view rather than the context in which it is being used.
		Props का नामकरण हम कौम्पोनॅन्टस के अनुसार करने की सलाह देते हैं बजाय उस संदर्भ में किया जाए जिसमें इसका उपयोग किया जा रहा है\|

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we break this into easier wording instead?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't find simple words.
I can just reverse the parts ...will that do ??

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

बजाय उस संदर्भ में किया जाए जिसमें इसका उपयोग किया जा रहा है| part is just a bit difficult, could we reword that and split it into 2 sentences that way?

Done till {#props-are-read-only}. 1 more section to go after this. So close 👍

added final set of comments. Almost there 🎆

@helios1101 any updates on this?

I'm having my college sessional exams, will revert once it gets over.

@helios1101 any updates on this?

I'm having my college sessional exams, will revert once it gets over.

no worries. Good luck!

I'm having my college sessional exams, will revert once it gets over.

no worries. Good luck!

@saranshkataria Plz have a look at the commit!