Translated editor-setup page to hindi by Subramanyarao11 · Pull Request #246 · reactjs/hi.react.dev

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@Subramanyarao11

Copy link

Contributor

No description provided.

Copy link

Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this.

I have added review for few lines, once these are fixes this will be go to be merged.

Copy link

Member

@arshadkazmi42 arshadkazmi42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks

@github-actions

Copy link

github-actions bot commented

Oct 2, 2023

Size changes

Details

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@arshadkazmi42 arshadkazmi42 merged commit a6af534 into reactjs:main

Oct 2, 2023

@Subramanyarao11

Copy link

Contributor Author

Looks good. Thanks
Thank you so much for your thorough review and valuable suggestions! Your guidance was instrumental in getting this code merged.

arshadkazmi42 reacted with rocket emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arshadkazmi42 arshadkazmi42 arshadkazmi42 approved these changes

Assignees

No one assigned

Labels

1st Review

First phase of review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Subramanyarao11 @arshadkazmi42