Translated editor-setup page to hindi by Subramanyarao11 · Pull Request #246 · reactjs/hi.react.dev
Navigation Menu
{{ message }}
reactjs / hi.react.dev Public
- Notifications You must be signed in to change notification settings
- Fork 133
Merged
arshadkazmi42 merged 4 commits intoreactjs:mainfrom
Oct 2, 2023Merged
Translated editor-setup page to hindi#246
arshadkazmi42 merged 4 commits intoreactjs:mainfrom
Translated editor-setup page to hindi#246
arshadkazmi42 merged 4 commits intoreactjs:mainfrom
Conversation
arshadkazmi42 requested changes Sep 29, 2023
Copy link
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for working on this.
I have added review for few lines, once these are fixes this will be go to be merged.
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
src/content/learn/editor-setup.md
Outdated
Show resolved
Hide resolved
src/content/learn/editor-setup.md Outdated Show resolved Hide resolved
Subramanyarao11
force-pushed
the
editor-setup
branch
from
5bc49eb to
704069f
Compare
Subramanyarao11
force-pushed
the
editor-setup
branch
from
365540c to
704069f
Compare
Subramanyarao11 added 3 commits
October 2, 2023 19:41arshadkazmi42 approved these changes Oct 2, 2023
Copy link
Member
arshadkazmi42
left a comment
arshadkazmi42
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks
Copy link
github-actions
bot
commented
Oct 2, 2023
github-actions bot commented
Oct 2, 2023Size changes
Details
📦 Next.js Bundle Analysis for react-dev
This analysis was generated by the Next.js Bundle Analysis action. 🤖
This PR introduced no changes to the JavaScript bundle! 🙌
arshadkazmi42
merged commit
a6af534
into
reactjs:main
arshadkazmi42
mentioned this pull request
Copy link
Contributor Author
Subramanyarao11
commented
Oct 3, 2023
Subramanyarao11 commented
Oct 3, 2023Looks good. Thanks
Thank you so much for your thorough review and valuable suggestions! Your guidance was instrumental in getting this code merged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment