API Reference > Test Utilities by paramaggarwal · Pull Request #45

API Reference > Test Utilities by paramaggarwal · Pull Request #45 · reactjs/hi.react.dev

Overview
Reference
- act()
- mockComponent()
- isElement()
- isElementOfType()
- isDOMComponent()
- isCompositeComponent()
- isCompositeComponentWithType()
- findAllInRenderedTree()
- scryRenderedDOMComponentsWithClass()
- findRenderedDOMComponentWithClass()
- scryRenderedDOMComponentsWithTag()
- findRenderedDOMComponentWithTag()
- scryRenderedComponentsWithType()
- findRenderedComponentWithType()
- renderIntoDocument()
Other Utilities
- Simulate

@paramaggarwal Good start. Let me know once you are done translating the whole file. I will start the review

paramaggarwal changed the title ~~[WIP] API Reference > Test Utilities~~ API Reference > Test Utilities

Sep 16, 2019

Ready.

Awesome. I will start reviewing this later today.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start.
I have added some feedbacks till line 124.

For review process do read #23

Thanks for the excellent feedback. I have addressed everything raised till now. We can continue further review.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work with the fixes.
I have reviewed the whole file and add couple of more feedbacks.
Once these are fixed it will be good to go from my end for second phase of review

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 💯
This is good to go from my end.
For next steps, there will be a second round of review done by @saranshkataria. Once that is done, we will get this merged

Comments addressed. Sorry for previously marking comments as "Resolved" - have not done so this time.

@paramaggarwal this has become confusing a bit to check which ones were resolved and which ones were not. Marking everything as resolved and starting the review afresh.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added comments till line 220

@paramaggarwal there are quite a few pending points. Could you look into those as well before we proceed with the review?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added final set of changes needed. Then this will be good to 👍

LGTM, Thanks! Merging it in