portals page by nooblyf · Pull Request #73 · reactjs/hi.react.dev
nooblyf
changed the title
complete portals page
portals page
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for taking this up and great start.
Added some reviews, once these are fixed, it will be good to go from my end.
Also, do read #23 to know about our review process.
@arshadkazmi42 I wrote "portal(s)" in english because it is listed in the glossary under No translation required and also method name is createPortal() so I think it will make more sense, no?
@arshadkazmi42 I wrote "portal(s)" in english because it is listed in the glossary under No translation required and also method name is
createPortal()so I think it will make more sense, no?
@Mayankverr Actually you are right. I completely forgot about it. Please ignore all my comments related to portals
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work. 🎉
Thank you for working on the fixes. For next steps, there will be another phase of review done by @saranshkataria , post that review we will get this merged
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added comments, once these are resolved, this is good to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters