Translate two articles (JSX and curly braces) by smikitky · Pull Request #459 · reactjs/ja.react.dev
Navigation Menu
{{ message }}
reactjs / ja.react.dev Public
- Notifications You must be signed in to change notification settings
- Fork 186
Merged
Translate two articles (JSX and curly braces)#459
Translate two articles (JSX and curly braces)#459
Conversation
Copy link
Member
smikitky
commented
Dec 16, 2021
smikitky
commented
- Writing Markup with JSX
- JavaScript in JSX with Curly Braces
ブランチプレビューのテストも兼ねています
- Writing Markup with JSX - JavaScript in JSX with Curly Braces
smikitky
mentioned this pull request
Copy link
Member Author
smikitky
commented
Dec 16, 2021
smikitky commented
Dec 16, 2021https://ja-beta-reactjs-org-kvts9dqap-fbopensource.vercel.app/learn/writing-markup-with-jsx
しっかりブランチプレビューも動作しているようです
Copy link
Member Author
相変わらず「Analyze Bundle / analyze (pull_request) 」のActionが動かないですね…
main ブランチで作られたアーチファクトを取りに行こうとして not found と言われているようです。
アーチファクトの保持期間自体はデフォルトの90日に設定されていたので、アーチファクトが本当に消えているというよりはパーミッション系の問題？
Copy link
Member Author
smikitky
commented
Dec 16, 2021
smikitky commented
Dec 16, 2021そもそも bundle_analysis_upload.yml などというワークフローファイルが既に存在しないので、それが原因ぽいですね…本家の方で直してもらう感じにします。
koba04
self-requested a review
koba04 approved these changes Dec 23, 2021
Copy link
Member
koba04
left a comment
koba04
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ありがとうございます！
一点、nits なコメントしましたが Approve するので適用するかはお任せします！
beta/src/pages/learn/writing-markup-with-jsx.md
Outdated
Show resolved
Hide resolved
beta/src/pages/learn/writing-markup-with-jsx.md Outdated Show resolved Hide resolved
Co-authored-by: Toru Kobayashi <koba0004@gmail.com>
smikitky
merged commit
3d74a82
into
main
smikitky
deleted the
tr/curly-and-props
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment