Translate Implementation-notes.md by baekjuwon · Pull Request #129 · reactjs/ko.react.dev
Copy link
Contributor
baekjuwon
commented
May 26, 2019
baekjuwon
commented
Progress
- 번역 초안 작성 (Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 모범사례 확인 (Check best practices)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
baekjuwon added 3 commits
May 26, 2019 15:42Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit f61e526
taehwanno
added
the
needs review
label
tesseralis
mentioned this pull request
gnujoow requested changes Oct 16, 2019
Copy link
Member
gnujoow
left a comment
gnujoow
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
전체적으로 번역투의 문장이 많이 사용된것 같습니다.
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
taehwanno requested changes Nov 5, 2019
Copy link
Member
taehwanno
left a comment
taehwanno
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세부적인 기술 내용이 많아서 리뷰에 시간이 많이 드네요 😢 피드백 드려요 ㅎㅎ
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
taehwanno requested changes Nov 5, 2019
Copy link
Member
taehwanno
left a comment
taehwanno
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
세부적인 기술 내용이 많아서 리뷰에 시간이 많이 드네요 😢 피드백 드려요 ㅎㅎ
taehwanno requested changes Nov 5, 2019
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
content/docs/implementation-notes.md
Outdated
Show resolved
Hide resolved
content/docs/implementation-notes.md Outdated Show resolved Hide resolved
taehwanno
added
needs author response
and removed
needs review
labels
Copy link
Member
taehwanno
commented
Mar 7, 2020
taehwanno commented
Mar 7, 2020제가 직접 수정해서 푸쉬할게요!
taehwanno added 4 commits
March 7, 2020 11:03taehwanno approved these changes Mar 7, 2020
Copy link
Member
taehwanno
left a comment
taehwanno
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
코드의 영어 주석 번역이 필요한데 일단 반영하고 다른 PR에서 추가 번역하는 방향으로 가겠습니다. 고생하셨습니다!
taehwanno
merged commit
b776c3c
into
reactjs:master
taehwanno
removed
the
needs author response
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters