Translate Introducing JSX by rkdmen · Pull Request #18 · reactjs/ko.react.dev
Navigation Menu
{{ message }}
reactjs / ko.react.dev Public
- Notifications You must be signed in to change notification settings
- Fork 536
Merged
hg-pyun merged 8 commits intoreactjs:masterfrom
Apr 19, 2019Merged
hg-pyun merged 8 commits intoreactjs:masterfrom
hg-pyun merged 8 commits intoreactjs:masterfrom
Conversation
tesseralis
mentioned this pull request
rkdmen
changed the title
First draft: introducing-jsx
Translate Introducing JSX
hg-pyun requested changes Feb 11, 2019
Copy link
Member
hg-pyun
left a comment
hg-pyun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
맞춤법이나 틀린 어휘표현이 보입니다. 전체적으로 맞춤법 검사기를 한번 돌려보는게 좋을 것 같습니다.
Copy link
Contributor Author
rkdmen
commented
Feb 11, 2019
rkdmen commented
Feb 11, 2019많이 틀렸네요 ㅎ..검사기 돌려 다 고쳤습니다.
taehwanno reviewed Feb 22, 2019
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
content/docs/introducing-jsx.md
Outdated
Show resolved
Hide resolved
content/docs/introducing-jsx.md Outdated Show resolved Hide resolved
Copy link
Member
taehwanno
commented
Feb 23, 2019
taehwanno commented
Feb 23, 2019upstream과 sync되면서 master 브랜치의 모든 링크 주소가 https로 변경되어 직접 충돌 해결했습니다.
Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit 0696b5b
Copy link
Member
taehwanno
commented
Feb 28, 2019
taehwanno commented
Feb 28, 2019@rkdmen 코멘트 피드백 부탁드릴게요 :)
taehwanno
added
the
needs author response
label
Copy link
Contributor Author
rkdmen
commented
Feb 28, 2019
rkdmen commented
Feb 28, 2019아 네- 제가 아직 확인 못햇어요 요즘 좀일이 바빠져서.. 조만간 확인 할게요-
Copy link
Member
gnujoow
commented
Apr 11, 2019
gnujoow commented
Apr 11, 2019@rkdmen 진행상황을 알 수 있을까요?
taehwanno
mentioned this pull request
Copy link
Member
taehwanno
commented
Apr 18, 2019
taehwanno commented
Apr 18, 20193주 이상 응답이 없는 Pull Request에 대해 직접 수정해서 푸쉬하도록 하겠습니다 :)
taehwanno added 4 commits
April 19, 2019 00:14Copy link
Member
taehwanno
commented
Apr 18, 2019
taehwanno commented
Apr 18, 2019직접 수정해서 푸쉬해놨습니다.
taehwanno approved these changes Apr 18, 2019
taehwanno
added
needs +1 approval
and removed
needs author response
labels
hg-pyun approved these changes Apr 19, 2019
Copy link
Member
hg-pyun
left a comment
hg-pyun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@taehwanno 고생하셨습니다. Approve 하겠습니다 :)
hg-pyun
added
ready to merge
and removed
needs +1 approval
labels
hg-pyun
merged commit
4c798f1
into
reactjs:master
rkdmen
deleted the
introducing-JSX-kor
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment