translating "testing-environments.md" to Korean by BeomYoung · Pull Request #183 · reactjs/ko.react.dev
Copy link
Contributor
Progress
- 번역 초안 작성 (Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 모범사례 확인 (Check best practices)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
BeomYoung added 10 commits
November 2, 2019 11:20Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit c3891da
tesseralis
mentioned this pull request
taehwanno
added
the
needs review
label
Copy link
Member
taehwanno
commented
Nov 8, 2019
taehwanno commented
Nov 8, 2019풀 리퀘스트 설명에 적혀있는 각 단계를 확인하시고 완료 하셨다면 체크 부탁드릴게요 ㅎㅎ
Copy link
Member
gnujoow
added
needs author response
and removed
needs review
labels
Copy link
Member
taehwanno
commented
Nov 14, 2019
taehwanno commented
Nov 14, 2019해당내용을 공통 스타일 가이드에 추가하려는데 괜찮을까요?
@gnujoow 공통 스타일 가이드라면 UNIVERSLA-STYLE-GUIDE.md를 의미하시는 걸까요? 해당 문서는 reactjs/reactjs.org-translation 저장소의 style-guide.md를 번역한 문서라 모범 사례 위키에 추가하는게 더 좋아보여요 ㅎㅎ
Copy link
Contributor Author
BeomYoung
commented
Nov 19, 2019
BeomYoung commented
Nov 19, 2019@gnujoow 말씀해주신대로 경어체로 수정 완료했습니다!
Copy link
Contributor Author
BeomYoung
commented
Nov 19, 2019
BeomYoung commented
Nov 19, 2019@taehwanno 제일 상단의 표의 내용도 번역을 진행하는 게 좋을까요?
id : testing-environments
title : Testing Environments
permalink : docs/testing-environments.html
prev : testing-recipes.html
Copy link
Member
gnujoow
commented
Nov 19, 2019
gnujoow commented
Nov 19, 2019@BeomYoung 상단 yaml 내용중에서 title내용만 번역 부탁드립니다
Copy link
Member
gnujoow
commented
Nov 19, 2019
gnujoow commented
Nov 19, 2019@BeomYoung
문단의 각 제목에는 id가 포함되어있습니다. 아래 문서와 pr 템플릿의 문서들을 읽어주시고 수정 부탁드립니다.
https://github.com/reactjs/ko.reactjs.org/blob/master/UNIVERSAL-STYLE-GUIDE.md#%EC%A0%9C%EB%AA%A9-%EC%95%84%EC%9D%B4%EB%94%94
Copy link
Contributor Author
BeomYoung
commented
Nov 19, 2019
BeomYoung commented
Nov 19, 2019@gnujoow 수정 완료했습니다. 확인 부탁드립니다
gnujoow requested changes Nov 19, 2019
Copy link
Member
gnujoow
left a comment
gnujoow
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
문서의 markdown 문법들이 모두 누락되어 있습니다. 아래 링크를 확인하셔서 누락된 markdown 문법들을 모두 추가해주세요.
https://ko.wikipedia.org/wiki/%EB%A7%88%ED%81%AC%EB%8B%A4%EC%9A%B4
Copy link
Contributor Author
BeomYoung
commented
Nov 19, 2019
BeomYoung commented
Nov 19, 2019@gnujoow 수정했습니다!
BeomYoung
requested a review
from gnujoow
taehwanno requested changes Nov 30, 2019
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md
Outdated
Show resolved
Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
Copy link
Contributor Author
BeomYoung
commented
Dec 1, 2019
BeomYoung commented
Dec 1, 2019@taehwanno 수정하신 내용 전부 확인했습니다! 감사합니다
taehwanno added 3 commits
May 10, 2020 14:16
taehwanno
removed
the
needs author response
label
taehwanno approved these changes May 10, 2020
Copy link
Member
taehwanno
left a comment
taehwanno
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 피드백 드린 거랑 원문 비교했을 때 수정해야할 부분 몇 가지 보여서 직접 처리했습니다! 고생하셨습니다.
taehwanno
merged commit
4cb7f9a
into
reactjs:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters