Translated HOC Page by dev-hikun · Pull Request #286 · reactjs/ko.react.dev
Copy link
Contributor
Progress
- 번역 초안 작성 (Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 모범사례 확인 (Check best practices)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
dev-hikun added 3 commits
February 16, 2021 16:51Copy link
netlify
bot
commented
Feb 16, 2021
netlify bot commented
Feb 16, 2021Deploy preview for ko-reactjs-org ready!
Built with commit 831aa92
Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit 0b2b564
taehwanno
mentioned this pull request
Copy link
Member
taehwanno
commented
Feb 16, 2021
taehwanno commented
Feb 16, 2021리뷰는 미리 배정받으신 분의 의사를 먼저 확인한 뒤에 진행하도록 하겠습니다 ㅎㅎ
Ref: #1 (comment)
Copy link
Member
taehwanno
commented
Feb 16, 2021
taehwanno commented
Feb 16, 2021#1 (comment) 미리 배정받으셨던 분이 허락해주셔서 리뷰 진행하도록 할게용
예전에 진행하다가 중단됐던 #187 도 연결시켜 둘게요 ㅎㅎ 몇 가지 리뷰 코멘트가 있으니 참고 부탁드리겠습니당
cc @junsikshim
taehwanno
added
the
needs review
label
Copy link
Contributor Author
@taehwanno @junsikshim 감사합니다!
저도 #187 보면서 진행했습니다
junsikshim reviewed Feb 17, 2021
Copy link
Contributor
junsikshim
left a comment
junsikshim
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
제가 작업했던 내용과 비교해서 커멘트를 남겼습니다~
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
taehwanno
added
needs author response
and removed
needs review
labels
hg-pyun reviewed Feb 17, 2021
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
Reflect Review
hg-pyun previously approved these changes Feb 19, 2021
Copy link
Member
hg-pyun
left a comment
hg-pyun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Copy link
Member
hg-pyun
commented
Feb 19, 2021
hg-pyun commented
Feb 19, 2021@junsikshim 확인 한번 부탁드려요!
hg-pyun
added
needs review
and removed
needs author response
labels
junsikshim reviewed Feb 21, 2021
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Show resolved
Hide resolved
content/docs/higher-order-components.md Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md
Outdated
Show resolved
Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
hg-pyun
added
needs author response
and removed
needs review
labels
오탈자 수정 및 리뷰 적용
dev-hikun
dismissed
hg-pyun’s stale review
via
33c878f
Copy link
Contributor Author
dev-hikun
commented
Feb 24, 2021
dev-hikun commented
Feb 24, 2021@junsikshim 좋은 리뷰들 감사합니다. 적용되었습니다.
@hg-pyun @taehwanno 확인 부탁드리겠습니다 :-)
junsikshim approved these changes Feb 24, 2021
hg-pyun approved these changes Feb 25, 2021
Copy link
Member
hg-pyun
left a comment
•
edited
Loading
hg-pyun
left a comment
•
edited
Loading
edited
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dev-hikun @junsikshim 두분 모두 고생하셨습니다!
LGTM
hg-pyun
added
ready to merge
and removed
needs author response
labels
hg-pyun
merged commit
b88c44e
into
reactjs:master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters