Translate: CodeEditor and CodeExample by taggon · Pull Request #361 · reactjs/ko.react.dev
Navigation Menu
{{ message }}
reactjs / ko.react.dev Public
- Notifications You must be signed in to change notification settings
- Fork 536
Merged
hg-pyun merged 2 commits intoreactjs:mainfrom
Oct 21, 2021Merged
Translate: CodeEditor and CodeExample#361
hg-pyun merged 2 commits intoreactjs:mainfrom
Translate: CodeEditor and CodeExample#361
hg-pyun merged 2 commits intoreactjs:mainfrom
Conversation
Copy link
Collaborator
Progress
- 번역 초안 작성 (Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 모범사례 확인 (Check best practices)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
반영하고 나면 웹 사이트에서 Live JSX Editor와 Result가 다음과 같이 한국어로 번역되어 나타납니다.
taggon
self-assigned this
taggon
mentioned this pull request
hg-pyun previously approved these changes Oct 20, 2021
Copy link
Member
hg-pyun
left a comment
hg-pyun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 오랜만에 기여 해주셨군요. 감사합니다 🙇
Copy link
Member
hg-pyun
commented
Oct 20, 2021
hg-pyun commented
Oct 20, 2021CI 한번 체크해주시면 될거같아요.
hg-pyun
added
the
ready to merge
label
taggon
dismissed
hg-pyun’s stale review
via
db88f8e
Copy link
Collaborator Author
taggon
commented
Oct 20, 2021
taggon commented
Oct 20, 2021@hg-pyun ㅎㅎ 넵. 오랜만에 번역한 거 올리네요. prettier가 커밋할 때 자동으로 실행될 줄 알았는데 그게 아니군요 ㄷㄷㄷ
hg-pyun approved these changes Oct 21, 2021
hg-pyun
merged commit
b3b1a70
into
reactjs:main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants