Translate Web Components by hiddenest · Pull Request #48 · reactjs/ko.react.dev
Conversation
Copy link
Contributor
Progress
- 번역 초안 작성(Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
hiddenest
mentioned this pull request
Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit 2706662
simsim0709 reviewed Feb 26, 2019
content/docs/web-components.md
Outdated
Show resolved
Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
Copy link
Contributor Author
hiddenest
commented
Feb 27, 2019
hiddenest commented
Feb 27, 2019@simsim0709 리뷰사항 반영하였습니다! 감사합니다 👍
taehwanno
added
needs review
and removed
needs review
labels
simsim0709
self-requested a review
simsim0709 added 2 commits
March 2, 2019 14:06`주의:`에서 콜론을 제거 했습니다. 현재 [textlint 룰](https://github.com/reactjs/ko.reactjs.org/blob/master/textlint/rules/no-endline-colon.js) 에서 문장 맨끝에 콜론 사용을 안하는 걸로 되어 있어서요.
simsim0709 previously approved these changes Mar 2, 2019
Copy link
Collaborator
simsim0709
left a comment
simsim0709
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다 👍
simsim0709
requested review from
gnujoow and
taehwanno
taehwanno reviewed Mar 2, 2019
content/docs/web-components.md
Outdated
Show resolved
Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
content/docs/web-components.md
Outdated
Show resolved
Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
content/docs/web-components.md
Outdated
Show resolved
Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
taehwanno
added
needs author response
and removed
needs +1 approval
labels
hiddenest
dismissed
simsim0709’s stale review
via
772743a
Copy link
Contributor Author
@taehwanno 리뷰해주신 내용 모두 반영하였습니다! 읽어주셔서 감사합니다 👍
@simsim0709 새로 푸시를 했더니 Approve가 해제되었습니다ㅠㅠ 다시 확인 부탁드려도 될까요?
taehwanno previously approved these changes Mar 3, 2019
taehwanno
added
needs +1 approval
and removed
needs author response
labels
gnujoow previously requested changes Mar 5, 2019
content/docs/web-components.md
Outdated
Show resolved
Hide resolved
content/docs/web-components.md Outdated Show resolved Hide resolved
simsim0709
dismissed
taehwanno’s stale review
via
2706662
simsim0709 approved these changes Mar 6, 2019
Copy link
Collaborator
simsim0709
left a comment
simsim0709
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~ 👍
taehwanno approved these changes Mar 6, 2019
taehwanno
merged commit
f5f90c3
into
reactjs:master
taehwanno
removed
the
needs +1 approval
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants