Translate dont-call-proptypes by simsim0709 · Pull Request #52 · reactjs/ko.react.dev
Conversation
Copy link
Collaborator
simsim0709
commented
Feb 28, 2019
simsim0709
commented
Progress
- 번역 초안 작성(Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
tesseralis
mentioned this pull request
Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit 46ce2c8
taehwanno
added
the
needs review
label
gnujoow previously approved these changes Mar 6, 2019
Copy link
Member
gnujoow
left a comment
gnujoow
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
gnujoow
added
needs +1 approval
and removed
needs review
labels
hg-pyun requested changes Mar 6, 2019
content/warnings/dont-call-proptypes.md
Outdated
Show resolved
Hide resolved
content/warnings/dont-call-proptypes.md Outdated Show resolved Hide resolved
content/warnings/dont-call-proptypes.md
Outdated
Show resolved
Hide resolved
content/warnings/dont-call-proptypes.md Outdated Show resolved Hide resolved
simsim0709
dismissed
gnujoow’s stale review
via
c8f018e
taehwanno reviewed Mar 7, 2019
content/warnings/dont-call-proptypes.md
Outdated
Show resolved
Hide resolved
content/warnings/dont-call-proptypes.md Outdated Show resolved Hide resolved
content/warnings/dont-call-proptypes.md
Outdated
Show resolved
Hide resolved
content/warnings/dont-call-proptypes.md Outdated Show resolved Hide resolved
content/warnings/dont-call-proptypes.md
Outdated
Show resolved
Hide resolved
content/warnings/dont-call-proptypes.md Outdated Show resolved Hide resolved
content/warnings/dont-call-proptypes.md
Outdated
Show resolved
Hide resolved
content/warnings/dont-call-proptypes.md Outdated Show resolved Hide resolved
taehwanno
added
needs author response
and removed
needs +1 approval
labels
simsim0709 added 2 commits
March 7, 2019 23:14
simsim0709
added
needs +1 approval
and removed
needs author response
labels
taehwanno approved these changes Mar 8, 2019
simsim0709
requested a review
from hg-pyun
hg-pyun approved these changes Mar 9, 2019
Copy link
Member
hg-pyun
left a comment
hg-pyun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
엘지티엠bb
taehwanno
merged commit
89ed75a
into
reactjs:master
taehwanno
removed
the
needs +1 approval
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment