Translate Hooks at a Glance by chatoo2412 · Pull Request #6 · reactjs/ko.react.dev
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have found some punctuation mistakes.
I havent read original docs and translation yet but it look good to me ;)
personally it is more familiar to read the term singular form in korean.
@gnujoow All resolved including the term Hooks. I agree with you that singular form is much familiar to Koreans, but I'm concerned that it's a technical term.
Why this pull request is not executed in CircleCI? I just enabled that before force-push. 😢
In addition, I set to require CircleCI tests to pass for merging into master branch.
hg-pyun previously approved these changes Feb 11, 2019
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@hg-pyun are you ready to merge this in?
hg-pyun previously approved these changes Feb 18, 2019
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
거의 다 된거 같아요 😄 자잘한 수정사항 제안드려봐요!
gnujoow
dismissed
hg-pyun’s stale review
수정사항이 반영되지 않아 review를 dismiss합니다. 최종 커밋이 올라온 이후에 review를 다시 진행하면 좋을것 같아요 ;)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters