Translate Hooks at a Glance by chatoo2412 · Pull Request #6 · reactjs/ko.react.dev

@chatoo2412

Please review and give me your feedback. 🙇

gnujoow

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found some punctuation mistakes.
I havent read original docs and translation yet but it look good to me ;)

personally it is more familiar to read the term singular form in korean.

@chatoo2412

@gnujoow All resolved including the term Hooks. I agree with you that singular form is much familiar to Koreans, but I'm concerned that it's a technical term.

@taehwanno

Why this pull request is not executed in CircleCI? I just enabled that before force-push. 😢
In addition, I set to require CircleCI tests to pass for merging into master branch.

@chatoo2412

@taehwanno

Thanks. I read that. but it doesn't work. Temporarily, I disable status checking before merging.

taggon

hg-pyun

hg-pyun previously approved these changes Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tesseralis

@hg-pyun are you ready to merge this in?

@hg-pyun

@hg-pyun

hg-pyun

hg-pyun previously approved these changes Feb 18, 2019

taehwanno

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

거의 다 된거 같아요 😄 자잘한 수정사항 제안드려봐요!

@gnujoow gnujoow dismissed hg-pyun’s stale review

February 21, 2019 16:40

수정사항이 반영되지 않아 review를 dismiss합니다. 최종 커밋이 올라온 이후에 review를 다시 진행하면 좋을것 같아요 ;)

@netlify

@taehwanno

1개 리뷰 누락된 것만 반영되면 이제 거의 다 된 것 같아요 🚀

@chatoo2412

hg-pyun

taehwanno