Translated typechecking-with-proptypes page into Korean by sukjae · Pull Request #78 · reactjs/ko.react.dev
Merged
simsim0709 merged 10 commits intoreactjs:masterfrom
sukjae:translate-typechecking-with-proptypes
Apr 9, 2019Merged
Translated typechecking-with-proptypes page into Korean#78
simsim0709 merged 10 commits intoreactjs:masterfrom
sukjae:translate-typechecking-with-proptypes
Translated typechecking-with-proptypes page into Korean#78
simsim0709 merged 10 commits intoreactjs:masterfrom
sukjae:translate-typechecking-with-proptypes
Conversation
Copy link
Contributor
Progress
- 번역 초안 작성 (Draft translation)
- 공통 스타일 가이드 확인 (Check the common style guide)
- 모범사례 확인 (Check best practices)
- 용어 확인 (Check the term)
- 맞춤법 검사 (Spelling check)
- 리뷰 반영 (Resolve reviews)
Copy link
Deploy preview for ko-reactjs-org ready!
Built with commit 2affa14
hg-pyun
added
the
needs review
label
hg-pyun previously requested changes Mar 25, 2019
Copy link
Member
hg-pyun
left a comment
hg-pyun
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
의견 남겨보았습니다. 확인 부탁드립니다 :)
content/docs/typechecking-with-proptypes.md
Outdated
Show resolved
Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md
Outdated
Show resolved
Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md
Outdated
Show resolved
Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
tesseralis
mentioned this pull request
simsim0709 reviewed Mar 27, 2019
content/docs/typechecking-with-proptypes.md
Outdated
Show resolved
Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
simsim0709 reviewed Mar 27, 2019
content/docs/typechecking-with-proptypes.md
Outdated
Show resolved
Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
simsim0709 reviewed Mar 27, 2019
content/docs/typechecking-with-proptypes.md
Outdated
Show resolved
Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
simsim0709
added
needs author response
and removed
needs review
labels
sukjae added 5 commits
March 27, 2019 17:23
simsim0709
added
needs +1 approval
and removed
needs author response
labels
simsim0709 added 2 commits
April 1, 2019 13:21
simsim0709
self-requested a review
simsim0709 approved these changes Apr 1, 2019
Copy link
Collaborator
simsim0709
left a comment
simsim0709
left a comment
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다~ 👍
gnujoow approved these changes Apr 9, 2019
simsim0709
merged commit
f39fd6b
into
reactjs:master
taehwanno
removed
the
needs +1 approval
label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment