Multi root adoption by aeschli · Pull Request #347 · redhat-developer/vscode-java
@aeschli can you sign-off your last commit please?
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we add the multi-root ready keyword as recommended or is it too early?
Not sure why this doesn't work.
Signed-off-by: Martin Aeschlimann <martinae@microsoft.com>
ok, all commits need to be signed (in eclipse.jdt.ls it just has to be the last).
That check is really a hassle. Please remove it again. I thought by becoming a contributor I've already agreed that all I commit is originated by me.
aeschli
deleted the
multi-root-adoption
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters