Support ZRANK and ZREVRANK: Added the optional WITHSCORE argument by codrin-ch · Pull Request #2489 · redis/node-redis
codrin-ch
marked this pull request as ready for review
@codrin-ch thanks for contributing!
The WITHSCORE argument should be implemented as a separate command since it has other return type (ZRANK_WITHSCORE and ZREVRANK_WITHSCORE). See ZDIFF_WITHSCORES for example.
I think the coverage missing is due to the redis version from the testing cluster.
The tests have the min version 7.2 and as a result I suspect that the tests are skipped for the new functions
@codrin-ch this is exactly what is happening. I'll add Redis 7.2 to the tests matrix soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters