Support ZRANK and ZREVRANK: Added the optional WITHSCORE argument by codrin-ch · Pull Request #2489 · redis/node-redis

@codrin-ch

Description

Describe your pull request here


Checklist

  • Does npm test pass with this change (including linting)?
  • Is the new or changed code fully tested?
  • Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?

fix #2463 and #2464

@codrin-ch

@codrin-ch codrin-ch marked this pull request as ready for review

April 29, 2023 11:28

@leibale

@codrin-ch thanks for contributing!
The WITHSCORE argument should be implemented as a separate command since it has other return type (ZRANK_WITHSCORE and ZREVRANK_WITHSCORE). See ZDIFF_WITHSCORES for example.

@codrin-ch

@codecov-commenter

@codrin-ch

@codrin-ch

I think the coverage missing is due to the redis version from the testing cluster.
The tests have the min version 7.2 and as a result I suspect that the tests are skipped for the new functions

@leibale

@codrin-ch this is exactly what is happening. I'll add Redis 7.2 to the tests matrix soon.

@leibale

@leibale

leibale added a commit to leibale/node-redis that referenced this pull request

Jun 22, 2023

@leibale

@TarSzator

Can something be done to finish this?