feat: add mouse event for react-native-web by Naturalclar · Pull Request #646 · rescript-react-native/rescript-react-native
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
feat: add mouse event for react-native-web#646
MoOx merged 2 commits intorescript-react-native:masterfrom
feat: add mouse event for react-native-web#646
MoOx merged 2 commits intorescript-react-native:masterfrom
Conversation
Copy link Copy Markdown
Member
Naturalclar
commented
Feb 8, 2020
Naturalclar
commented
Closes #645
Adding onMouseEnter, onMouseLeave props for View, Text, TextInput
ref: https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/View/filterSupportedProps.js
https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/Text/index.js
https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/View/index.js
https://github.com/necolas/react-native-web/blob/master/packages/react-native-web/src/exports/TextInput/index.js
Copy link Copy Markdown
Member
MoOx
commented
Feb 18, 2020
MoOx commented
Feb 18, 2020While doing this, maybe we could handle all mouse event? See supported ones here https://github.com/necolas/react-native-web/blob/5b7f584f191d8fb6e5c92fa560c4e6babca7559f/packages/react-native-web/src/exports/View/filterSupportedProps.js#L58-L65
Copy link Copy Markdown
Member Author
Naturalclar
commented
Feb 22, 2020
Naturalclar commented
Feb 22, 2020@MoOx
Thanks! I've added the other mouse events as well 👍
Naturalclar
requested a review
from MoOx
Copy link Copy Markdown
Member
jfrolich
commented
Mar 3, 2020
jfrolich commented
Mar 3, 2020Would be great if this can ship soon! 🚀
MoOx approved these changes Mar 26, 2020
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Sorry for the delay!
MoOx
merged commit
2703957
into
rescript-react-native:master
Naturalclar
deleted the
feat/645
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants