Add Global.hermesInternal by MoOx · Pull Request #613 · rescript-react-native/rescript-react-native

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Merged

MoOx merged 2 commits intomasterfrom

hermesflag

Sep 23, 2019

Merged

Add Global.hermesInternal#613

MoOx merged 2 commits intomasterfrom

hermesflag

Conversation

@MoOx

Copy link Copy Markdown

Member

@MoOx MoOx commented

Sep 20, 2019

Closes #610

@MoOx MoOx requested review from cknitt and sgny

September 20, 2019 10:25
Copy link Copy Markdown

Collaborator

@sgny sgny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I suppose I have already cast my vote for this 😄

@MoOx MoOx merged commit 6c6772b into master

Sep 23, 2019

@MoOx MoOx deleted the hermesflag branch

September 23, 2019 14:17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cknitt cknitt cknitt approved these changes

@sgny sgny sgny approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Exposing global.HermesInternal

3 participants

@MoOx @cknitt @sgny