update type for DrawerLayoutAndroid drawerPosition prop by sgny · Pull Request #626 · rescript-react-native/rescript-react-native

Conversation

@sgny

Constants Left and Right are no longer defined, the prop accepts either "left" or "right" as string.

MoOx

MoOx approved these changes Nov 12, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea since when it's this way?

@sgny

Quite recent, only as of 0.61.0.

@MoOx

Ok I missed that in RN 0.61 release notes. Merging & will cut a release tomorrow with all the latests stuff

@MoOx MoOx deleted the drawerPosition branch

November 14, 2019 10:41

2 participants

@sgny @MoOx