Fix autoCompleteType prop for text input component by Naturalclar · Pull Request #639 · rescript-react-native/rescript-react-native
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
MoOx merged 1 commit intorescript-react-native:masterfrom
Jan 26, 2020Merged
Fix autoCompleteType prop for text input component#639
MoOx merged 1 commit intorescript-react-native:masterfrom
Fix autoCompleteType prop for text input component#639
MoOx merged 1 commit intorescript-react-native:masterfrom
Conversation
Copy link Copy Markdown
Member
Naturalclar
commented
Jan 20, 2020
Naturalclar
commented
Closes #634
Changed autoComplete prop in TextInput to autoCompleteType
React Native Ref: https://github.com/facebook/react-native/blob/master/Libraries/Components/TextInput/TextInput.js#L313
Naturalclar
requested a review
from MoOx
sgny approved these changes Jan 25, 2020
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked against RN documentation, prop name and allowed values look alright
MoOx approved these changes Jan 26, 2020
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
MoOx
merged commit
ec50b5f
into
rescript-react-native:master
Naturalclar
deleted the
fix/textInputProps
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants