Re-add NativeEventEmitter. by cknitt · Pull Request #642 · rescript-react-native/rescript-react-native
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Conversation
Copy link Copy Markdown
Member
cknitt
commented
Jan 25, 2020
cknitt
commented
NativeEventEmitter was already present in the old bindings (https://github.com/reason-react-native/bs-react-native/blob/master/src/nativeEventEmitter.re), but somehow got lost. Re-adding it.
cknitt
requested review from
MoOx and
sgny
Copy link Copy Markdown
Collaborator
sgny
commented
Jan 25, 2020
sgny commented
Jan 25, 2020@cknitt Have you had a chance to test them, or are you carrying them over?
Copy link Copy Markdown
Member Author
cknitt
commented
Jan 25, 2020
cknitt commented
Jan 25, 2020Last week, I ported an app where NativeEventEmitter was used from the old bindings to the new ones. In the course of this work, I noticed NativeEventEmitter was missing and re-added it.
Copy link Copy Markdown
Collaborator
sgny
commented
Jan 25, 2020
sgny commented
Jan 25, 2020Alright, that’s what I was trying to figure out. Merging
sgny approved these changes Jan 25, 2020
sgny
merged commit
923c1df
into
master
MoOx
deleted the
native-event-emitter
branch
Copy link Copy Markdown
Member
MoOx
commented
Jan 26, 2020
MoOx commented
Jan 26, 2020Nice! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants