Fix a very minor typo in Global.re by fa7ad · Pull Request #703 · rescript-react-native/rescript-react-native

Skip to content

Navigation Menu

Sign in

Appearance settings

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up

Appearance settings

Conversation

@fa7ad

Copy link Copy Markdown

Contributor

@fa7ad fa7ad commented

Jul 11, 2020

The JavaScript version of global.HermesInternal uses an uppercase H instead of lowercase. I assume it was a typo in reason.

the JavaScript version of global.HermesInternal uses an uppercase H instead of lowercase.
Copy link Copy Markdown

Member

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@MoOx MoOx merged commit 73509eb into rescript-react-native:master

Jul 15, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoOx MoOx MoOx approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@fa7ad @MoOx