feature/LogBox by idkjs · Pull Request #711 · rescript-react-native/rescript-react-native
Closes no issues.
I got tired of seeing the warning so I figured we needed a binding to it.
Best!
MoOx
mentioned this pull request
11 tasks
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Little details to fix for doc & it will be good!
| title: LogBox | ||
| officialDoc: https://reactnative.dev/docs/debugging#logbox | ||
| --- | ||
| ## [LogBox](https://reactnative.dev/docs/debugging#logbox) |
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This title is redundant, page will generate it from title.
Also you can then update the ### to ##
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed it.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still see this. And I don't see the other title adjusted neither.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must not have pushed the edit. I see it here now.
Co-authored-by: Max Thirouin <git@moox.io>
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
I pushed a minor change. Merging! Thanks!
MoOx approved these changes Aug 20, 2020
MoOx
deleted the
feature/LogBox
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters