Add binding for PlatformColor by celsobonutti · Pull Request #716 · rescript-react-native/rescript-react-native

Closed

celsobonutti wants to merge 4 commits intorescript-react-native:masterfrom

celsobonutti:feat/platform_color

Closed

Add binding for PlatformColor#716
celsobonutti wants to merge 4 commits intorescript-react-native:masterfrom
celsobonutti:feat/platform_color

Conversation

Copy link Copy Markdown

Contributor

celsobonutti commented
Aug 26, 2020

This PR adds PlatformColor

celsobonutti added 4 commits

August 25, 2020 19:30

Added PlatformColor + documentation draft

be06e57

Case and naming adjustments

252f4e3

Better documentation

01d4ece

Fixes documentation links

f7895fc

MoOx requested changes Sep 11, 2020

View reviewed changes

Copy link Copy Markdown

Member

MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi. Thanks for the contribution!
We are trying to have only zero cost bindings to avoid additional cost & layer prone to error.
Ideally, except some very minor thing that we should be able to remove thanks to BS 8.2, the JavaScript code produced should directly hit React & React Native JavaScript implementation, without any extra runtime & bundle cost.
We prefer low level, more verbose bindings instead of "an interpretation" layer. Do you think you can adjust your bindings to match this philosophy?

MoOx mentioned this pull request