Accessibility changes for 0.63 by cknitt · Pull Request #728 · rescript-react-native/rescript-react-native
Navigation Menu
{{ message }}
- Notifications You must be signed in to change notification settings
- Fork 151
Merged
Conversation
Copy link Copy Markdown
Member
cknitt
commented
Sep 27, 2020
cknitt
commented
This is the accessibility stuff from #705.
- Removed accessibilityComponentType and accessibilityTraits.
- Accessibility.role was actually already up to date (except for the value "switch" which we can't add because it's a keyword, unless we move this back to
@bs.stringwhich I would like to avoid). - Accessibility.actionInfo was already there, but broken (missing
unitto terminate argument list) => fixed. - Added
AccessibilityActionEventandonAccessibilityAction.
cknitt
requested a review
from MoOx
cknitt added 2 commits
September 27, 2020 12:29
cknitt
force-pushed
the
accessibility-0.63
branch
from
5290b33 to
191ce6e
Compare
MoOx approved these changes Sep 28, 2020
MoOx
merged commit
840d682
into
master
MoOx
deleted the
accessibility-0.63
branch
Copy link Copy Markdown
Member
MoOx
commented
Sep 28, 2020
MoOx commented
Sep 28, 2020Thanks for handling this @cknitt !
fakenickels
mentioned this pull request
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants