SAGE Journals by oguzhanogreden · Pull Request #181

SAGE Journals by oguzhanogreden · Pull Request #181 · rstudio/rticles

I added the SAGE journals.

Let me know if there's anything further to do!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks excellent! Did you sign the contributor agreement?

Sorry that I didn't write in the first place that I would do it after you took a look.

I sent the email just now.

@yihui Contributor agreement is signed.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few large .cls/.bst files under inst/rmarkdown/templates/sage_article/skeleton seem to be duplicated under inst/rmarkdown/templates/sage_article/resources. Could you remove the latter ones?

		rticles 0.5
		---------------------------------------------------------------------

		- Added the template for the SAGE Journals (thanks, @oguzhanogreden).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the PR number #181.

		person("Dominik", "Leutnant", role = c("aut", "cph"), email = "leutnant@fh-muenster.de"),
		person(family = "MDPI", role = c("aut", "cph"))
		person(family = "MDPI", role = c("aut", "cph")),
		person("Oğuzhan", "Öğreden", role = c("ctb"), comment = c(ORCID = "0000-0002-9949-3348"))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to make yourself aut instead of ctb if you want.

Done. Please note that I used inst/rmarkdown/templates/sim_article/ folder structure as a template, which also contain the duplicate of the .cls file as well.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. Thanks!

I'll get rid of the duplicated .cls file in sim_article, and thanks for catching that!

yihui added a commit that referenced this pull request

Jul 12, 2018

yihui added a commit that referenced this pull request

Jul 12, 2018

yihui mentioned this pull request

Nov 20, 2018

github-actions bot locked as resolved and limited conversation to collaborators

Nov 2, 2020