Template for the journals from American Meteorological Society by yufree · Pull Request #96

Template for the journals from American Meteorological Society by yufree · Pull Request #96 · rstudio/rticles

		@@ -0,0 +1,70 @@
		\documentclass[$col$]{ametsoc}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any of the pandoc includes in this template (e.g. include-header, include-before, include-after). Should these be added?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's convenient!
I also add include-header into the ACS template.
Thanks!

change col into layout to make it clear

		test_format("jss_article")
		test_format("rjournal_article", file_check = FALSE)
		test_format("acs_article", os_skip = "windows")
		test_format("acs_article", file_check = FALSE)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests run fine in mac and Linux.
However, for windows I found tests failed and I set the file_check to false to pass tests both for acs and ams template. Such templates could be used in windows, just do not pass the unit tests. I think the reason would be the path of the figures generated by the templates.
The pnas template also can not pass the test right now and also could be used in windows. I think os_skip would work for it while file_check does not work.

		% pandoc header
		$for(header-includes)$
		$header-includes$
		$endfor$

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot and I fixed it.

github-actions bot locked as resolved and limited conversation to collaborators

Nov 2, 2020