feat(reslve): Respect '--ignore-rust-version' by epage · Pull Request #13738 · rust-lang/cargo

added 3 commits

April 11, 2024 11:40

@epage epage mentioned this pull request

Apr 11, 2024

27 tasks

Muscraft

@epage epage mentioned this pull request

Apr 11, 2024

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 11, 2024

bors added a commit that referenced this pull request

Apr 11, 2024
feat(reslve): Respect '--ignore-rust-version'

### What does this PR try to resolve?

This is a part of #9930.

### How should we test and review this PR?

I had considered several ways of implementing this.  I first looked at passing this into `ops::resolve*`.
.This would get a bit annoying with the function signature, so I considered moving it to a builder..
Each of the entry points is slightly different with different ownership needs, making it hard to have a common abstraction.
In doing this, I noticed we currently pass some state around to the resolver via `Workspace`, so I mirrored that.

The nice thing about this location is it provides a good place to hook in config and `package.resolve` so they affect this.

### Additional information

@bors bors added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Apr 11, 2024

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 11, 2024

weihanglo

bors added a commit that referenced this pull request

Apr 12, 2024
fix(help): Generalize --ignore-rust-version

### What does this PR try to resolve?

This is part of #9930 and updates for the help to accommodate #13738 and adding `--ignore-rust-version` to `cargo update`  for when they are stable

This includes
- Moving `--ignore-rust-version` to be under the "Manifest options" header
- Generalizing the help description

### How should we test and review this PR?

### Additional information

epage added a commit to epage/cargo that referenced this pull request

Apr 12, 2024

@epage epage mentioned this pull request

Apr 12, 2024

bors added a commit that referenced this pull request

Apr 12, 2024

epage added a commit to epage/cargo that referenced this pull request

Apr 12, 2024

bors added a commit that referenced this pull request

Apr 12, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 13, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 13, 2024