Stabilize default_alloc_error_handler by Amanieu · Pull Request #102318 · rust-lang/rust
added
the
T-compiler
label
Sep 26, 2022Amanieu added a commit to Amanieu/rust that referenced this pull request
Oct 31, 2022The new implementation doesn't use weak lang items and instead changes `#[alloc_error_handler]` to an attribute macro just like `#[global_allocator]`. The attribute will generate the `__rg_oom` function which is called by the compiler-generated `__rust_alloc_error_handler`. If no `__rg_oom` function is defined in any crate then the compiler shim will call `__rdl_oom` in the alloc crate which will simply panic. This also fixes link errors with `-C link-dead-code` with `default_alloc_error_handler`: `__rg_oom` was previously defined in the alloc crate and would attempt to reference the `oom` lang item, even if it didn't exist. This worked as long as `__rg_oom` was excluded from linking since it was not called. This is a prerequisite for the stabilization of `default_alloc_error_handler` (rust-lang#102318).
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request
Nov 1, 2022…r, r=bjorn3 Rewrite implementation of `#[alloc_error_handler]` The new implementation doesn't use weak lang items and instead changes `#[alloc_error_handler]` to an attribute macro just like `#[global_allocator]`. The attribute will generate the `__rg_oom` function which is called by the compiler-generated `__rust_alloc_error_handler`. If no `__rg_oom` function is defined in any crate then the compiler shim will call `__rdl_oom` in the alloc crate which will simply panic. This also fixes link errors with `-C link-dead-code` with `default_alloc_error_handler`: `__rg_oom` was previously defined in the alloc crate and would attempt to reference the `oom` lang item, even if it didn't exist. This worked as long as `__rg_oom` was excluded from linking since it was not called. This is a prerequisite for the stabilization of `default_alloc_error_handler` (rust-lang#102318).
rustbot
added
the
A-translation
label
Nov 3, 2022
Amanieu
marked this pull request as ready for review
rustbot
added
S-waiting-on-review
and removed S-waiting-on-author
Status: This is awaiting some action (such as code changes or more information) from the author.labels
Nov 3, 2022nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 4, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 4, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 4, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 4, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 4, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 4, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request
Mar 7, 2023The new implementation doesn't use weak lang items and instead changes `#[alloc_error_handler]` to an attribute macro just like `#[global_allocator]`. The attribute will generate the `__rg_oom` function which is called by the compiler-generated `__rust_alloc_error_handler`. If no `__rg_oom` function is defined in any crate then the compiler shim will call `__rdl_oom` in the alloc crate which will simply panic. This also fixes link errors with `-C link-dead-code` with `default_alloc_error_handler`: `__rg_oom` was previously defined in the alloc crate and would attempt to reference the `oom` lang item, even if it didn't exist. This worked as long as `__rg_oom` was excluded from linking since it was not called. This is a prerequisite for the stabilization of `default_alloc_error_handler` (rust-lang#102318).
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 7, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 7, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 9, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 9, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 12, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 13, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to nicholasbishop/uefi-rs that referenced this pull request
Mar 19, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
nicholasbishop added a commit to rust-osdev/uefi-rs that referenced this pull request
Mar 19, 2023As of 2022-12-18, we can rely on the `default_alloc_error_handler` feature which was stabilized in rust-lang/rust#102318. The behavior of the default handler is to panic, essentially the same as our current custom one.
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request
Apr 8, 2023Pkgsrc changes: * Adjust patches (add & remove) and cargo checksums to new versions. * It's conceivable that the workaround for LLVM based NetBSD works even less in this version (ref. PKGSRC_HAVE_LIBCPP not having a corresponding patch anymore). Upstream changes: Version 1.68.2 (2023-03-28) =========================== - [Update the GitHub RSA host key bundled within Cargo] (rust-lang/cargo#11883). The key was [rotated by GitHub] (https://github.blog/2023-03-23-we-updated-our-rsa-ssh-host-key/) on 2023-03-24 after the old one leaked. - [Mark the old GitHub RSA host key as revoked] (rust-lang/cargo#11889). This will prevent Cargo from accepting the leaked key even when trusted by the system. - [Add support for `@revoked` and a better error message for `@cert-authority` in Cargo's SSH host key verification] (rust-lang/cargo#11635) Version 1.68.1 (2023-03-23) =========================== - [Fix miscompilation in produced Windows MSVC artifacts] (rust-lang/rust#109094) This was introduced by enabling ThinLTO for the distributed rustc which led to miscompilations in the resulting binary. Currently this is believed to be limited to the -Zdylib-lto flag used for rustc compilation, rather than a general bug in ThinLTO, so only rustc artifacts should be affected. - [Fix --enable-local-rust builds] (rust-lang/rust#109111) - [Treat `$prefix-clang` as `clang` in linker detection code] (rust-lang/rust#109156) - [Fix panic in compiler code] (rust-lang/rust#108162) Version 1.68.0 (2023-03-09) =========================== Language -------- - [Stabilize default_alloc_error_handler] (rust-lang/rust#102318) This allows usage of `alloc` on stable without requiring the definition of a handler for allocation failure. Defining custom handlers is still unstable. - [Stabilize `efiapi` calling convention.] (rust-lang/rust#105795) - [Remove implicit promotion for types with drop glue] (rust-lang/rust#105085) Compiler -------- - [Change `bindings_with_variant_name` to deny-by-default] (rust-lang/rust#104154) - [Allow .. to be parsed as let initializer] (rust-lang/rust#105701) - [Add `armv7-sony-vita-newlibeabihf` as a tier 3 target] (rust-lang/rust#105712) - [Always check alignment during compile-time const evaluation] (rust-lang/rust#104616) - [Disable "split dwarf inlining" by default.] (rust-lang/rust#106709) - [Add vendor to Fuchsia's target triple] (rust-lang/rust#106429) - [Enable sanitizers for s390x-linux] (rust-lang/rust#107127) Libraries --------- - [Loosen the bound on the Debug implementation of Weak.] (rust-lang/rust#90291) - [Make `std::task::Context` !Send and !Sync] (rust-lang/rust#95985) - [PhantomData layout guarantees] (rust-lang/rust#104081) - [Don't derive Debug for `OnceWith` & `RepeatWith`] (rust-lang/rust#104163) - [Implement DerefMut for PathBuf] (rust-lang/rust#105018) - [Add O(1) `Vec -> VecDeque` conversion guarantee] (rust-lang/rust#105128) - [Leak amplification for peek_mut() to ensure BinaryHeap's invariant is always met] (rust-lang/rust#105851) Stabilized APIs --------------- - [`{core,std}::pin::pin!`] (https://doc.rust-lang.org/stable/std/pin/macro.pin.html) - [`impl From<bool> for {f32,f64}`] (https://doc.rust-lang.org/stable/std/primitive.f32.html#impl-From%3Cbool%3E-for-f32) - [`std::path::MAIN_SEPARATOR_STR`] (https://doc.rust-lang.org/stable/std/path/constant.MAIN_SEPARATOR_STR.html) - [`impl DerefMut for PathBuf`] (https://doc.rust-lang.org/stable/std/path/struct.PathBuf.html#impl-DerefMut-for-PathBuf) These APIs are now stable in const contexts: - [`VecDeque::new`] (https://doc.rust-lang.org/stable/std/collections/struct.VecDeque.html#method.new) Cargo ----- - [Stabilize sparse registry support for crates.io] (rust-lang/cargo#11224) - [`cargo build --verbose` tells you more about why it recompiles.] (rust-lang/cargo#11407) - [Show progress of crates.io index update even `net.git-fetch-with-cli` option enabled] (rust-lang/cargo#11579) Misc ---- Compatibility Notes ------------------- - [Add `SEMICOLON_IN_EXPRESSIONS_FROM_MACROS` to future-incompat report] (rust-lang/rust#103418) - [Only specify `--target` by default for `-Zgcc-ld=lld` on wasm] (rust-lang/rust#101792) - [Bump `IMPLIED_BOUNDS_ENTAILMENT` to Deny + ReportNow] (rust-lang/rust#106465) - [`std::task::Context` no longer implements Send and Sync] (rust-lang/rust#95985) nternal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Encode spans relative to the enclosing item] (rust-lang/rust#84762) - [Don't normalize in AstConv] (rust-lang/rust#101947) - [Find the right lower bound region in the scenario of partial order relations] (rust-lang/rust#104765) - [Fix impl block in const expr] (rust-lang/rust#104889) - [Check ADT fields for copy implementations considering regions] (rust-lang/rust#105102) - [rustdoc: simplify JS search routine by not messing with lev distance] (rust-lang/rust#105796) - [Enable ThinLTO for rustc on `x86_64-pc-windows-msvc`] (rust-lang/rust#103591) - [Enable ThinLTO for rustc on `x86_64-apple-darwin`] (rust-lang/rust#103647) Version 1.67.0 (2023-01-26) ========================== Language -------- - [Make `Sized` predicates coinductive, allowing cycles.] (rust-lang/rust#100386) - [`#[must_use]` annotations on `async fn` also affect the `Future::Output`.] (rust-lang/rust#100633) - [Elaborate supertrait obligations when deducing closure signatures.] (rust-lang/rust#101834) - [Invalid literals are no longer an error under `cfg(FALSE)`.] (rust-lang/rust#102944) - [Unreserve braced enum variants in value namespace.] (rust-lang/rust#103578) Compiler -------- - [Enable varargs support for calling conventions other than `C` or `cdecl`.] (rust-lang/rust#97971) - [Add new MIR constant propagation based on dataflow analysis.] (rust-lang/rust#101168) - [Optimize field ordering by grouping m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) - [Stabilize native library modifier `verbatim`.] (rust-lang/rust#104360) Added and removed targets: - [Add a tier 3 target for PowerPC on AIX] (rust-lang/rust#102293), `powerpc64-ibm-aix`. - [Add a tier 3 target for the Sony PlayStation 1] (rust-lang/rust#102689), `mipsel-sony-psx`. - [Add tier 3 `no_std` targets for the QNX Neutrino RTOS] (rust-lang/rust#102701), `aarch64-unknown-nto-qnx710` and `x86_64-pc-nto-qnx710`. - [Remove tier 3 `linuxkernel` targets] (rust-lang/rust#104015) (not used by the actual kernel). Refer to Rust's [platform support page][platform-support-doc] for more information on Rust's tiered platform support. Libraries --------- - [Merge `crossbeam-channel` into `std::sync::mpsc`.] (rust-lang/rust#93563) - [Fix inconsistent rounding of 0.5 when formatted to 0 decimal places.] (rust-lang/rust#102935) - [Derive `Eq` and `Hash` for `ControlFlow`.] (rust-lang/rust#103084) - [Don't build `compiler_builtins` with `-C panic=abort`.] (rust-lang/rust#103786) Stabilized APIs --------------- - [`{integer}::checked_ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog) - [`{integer}::checked_ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog2) - [`{integer}::checked_ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.checked_ilog10) - [`{integer}::ilog`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog) - [`{integer}::ilog2`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog2) - [`{integer}::ilog10`] (https://doc.rust-lang.org/stable/std/primitive.i32.html#method.ilog10) - [`NonZeroU*::ilog2`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog2) - [`NonZeroU*::ilog10`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#method.ilog10) - [`NonZero*::BITS`] (https://doc.rust-lang.org/stable/std/num/struct.NonZeroU32.html#associatedconstant.BITS) These APIs are now stable in const contexts: - [`char::from_u32`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_u32) - [`char::from_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.from_digit) - [`char::to_digit`] (https://doc.rust-lang.org/stable/std/primitive.char.html#method.to_digit) - [`core::char::from_u32`] (https://doc.rust-lang.org/stable/core/char/fn.from_u32.html) - [`core::char::from_digit`] (https://doc.rust-lang.org/stable/core/char/fn.from_digit.html) Compatibility Notes ------------------- - [The layout of `repr(Rust)` types now groups m\*2^n-sized fields with equivalently aligned ones.] (rust-lang/rust#102750) This is intended to be an optimization, but it is also known to increase type sizes in a few cases for the placement of enum tags. As a reminder, the layout of `repr(Rust)` types is an implementation detail, subject to change. - [0.5 now rounds to 0 when formatted to 0 decimal places.] (rust-lang/rust#102935) This makes it consistent with the rest of floating point formatting that rounds ties toward even digits. - [Chains of `&&` and `||` will now drop temporaries from their sub-expressions in evaluation order, left-to-right.] (rust-lang/rust#103293) Previously, it was "twisted" such that the _first_ expression dropped its temporaries _last_, after all of the other expressions dropped in order. - [Underscore suffixes on string literals are now a hard error.] (rust-lang/rust#103914) This has been a future-compatibility warning since 1.20.0. - [Stop passing `-export-dynamic` to `wasm-ld`.] (rust-lang/rust#105405) - [`main` is now mangled as `__main_void` on `wasm32-wasi`.] (rust-lang/rust#105468) - [Cargo now emits an error if there are multiple registries in the configuration with the same index URL.] (rust-lang/cargo#10592) Internal Changes ---------------- These changes do not affect any public interfaces of Rust, but they represent significant improvements to the performance or internals of rustc and related tools. - [Rewrite LLVM's archive writer in Rust.] (rust-lang/rust#97485)
antoyo pushed a commit to antoyo/rust that referenced this pull request
Jun 19, 2023The new implementation doesn't use weak lang items and instead changes `#[alloc_error_handler]` to an attribute macro just like `#[global_allocator]`. The attribute will generate the `__rg_oom` function which is called by the compiler-generated `__rust_alloc_error_handler`. If no `__rg_oom` function is defined in any crate then the compiler shim will call `__rdl_oom` in the alloc crate which will simply panic. This also fixes link errors with `-C link-dead-code` with `default_alloc_error_handler`: `__rg_oom` was previously defined in the alloc crate and would attempt to reference the `oom` lang item, even if it didn't exist. This worked as long as `__rg_oom` was excluded from linking since it was not called. This is a prerequisite for the stabilization of `default_alloc_error_handler` (rust-lang#102318).
byeongkeunahn added a commit to byeongkeunahn/basm-rs that referenced this pull request
Jan 24, 2024byeongkeunahn added a commit to byeongkeunahn/basm-rs that referenced this pull request
Jan 24, 2024byeongkeunahn added a commit to byeongkeunahn/basm-rs that referenced this pull request
Jan 25, 2024github-merge-queue bot pushed a commit to stellar/rs-soroban-sdk that referenced this pull request
Mar 28, 2025Part of wrapping up bug #1428. Mostly this is just: - Switching rust version to 1.84 which supports `wasm32v1-none` - Switching the SDK to build with that, not `wasm32-unknown-unknown` But there are a couple minor subtle bits: - Some of the crates only build native, not wasm, and we weren't differentiating that in the Makefile right - There _used_ to be a workaround for a mis-feature of `alloc` that required `std` in order to register an OOM handler; this was actually fixed in March 2023 (https://releases.rs/docs/1.68.0/ which contained rust-lang/rust#102318) but the workaround was already committed to the SDK by January 2023. Anyway, it's long since fixed and we can just delete the workaround, which we _have_ to in this PR, because `wasm32v1-none` doesn't ship with `std` at all. Probably don't merge this until I have the other CI bits all switched over to `wasm32v1-none` as described in #1428 --------- Co-authored-by: Leigh McCulloch <351529+leighmcculloch@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters