Home Original page

Don't copy symbols from dylibs with `-Zdylib-lto` by lqd · Pull Request #105800 · rust-lang/rust

added 2 commits

December 16, 2022 20:39

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 16, 2022

@lqd lqd marked this pull request as ready for review

December 17, 2022 01:15

@lqd lqd mentioned this pull request

Dec 17, 2022

bjorn3

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Dec 17, 2022

@lqd lqd deleted the dylib-thinlto branch

December 17, 2022 18:12

This was referenced

Dec 17, 2022

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 19, 2022 
…mulacrum

Re-enable ThinLTO for rustc on `x86_64-apple-darwin`

ThinLTO was disabled on x64 mac in rust-lang#105646 because of the rust-lang#105637 regression.

It was later discovered that the issue was present on other targets as well, as the mac revert was already landing. The linux/win reverts, however, did not land before the root cause was identified.

rust-lang#105800 fixed the underlying issue in `-Zdylib-lto` handling, and the x64 msvc and linux targets are now fixed, ICEs are using the correct `rustc_driver` panic hook.

This PR re-enables ThinLTO on mac for improved perf now that the issue should be fixed everywhere.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 27, 2022 
…mulacrum

[beta] backport rollup

* Revert "Replace usage of ResumeTy in async lowering with Context" rust-lang#105915
*  Don't copy symbols from dylibs with -Zdylib-lto rust-lang#105800
*  rustdoc: Only hide lines starting with # in rust code blocks rust-lang#105539
*  Mangle "main" as "__main_void" on wasm32-wasi rust-lang#105468

r? `@ghost`

@lqd lqd mentioned this pull request

Dec 28, 2022