…, r=compiler-errors

Silence some follow-up errors [1/x]

this is one piece of the requested cleanups from rust-lang#117449

When we use `-> impl SomeTrait<_>` as a return type, we are both using the "infer return type suggestion" code path, and the infer opaque type code path within the same function. That can lead to confusing diagnostics, so silence all opaque type diagnostics in that case.

Rollup merge of rust-lang#119803 - oli-obk:even_more_follow_up_errors, r=compiler-errors

Silence some follow-up errors [1/x]

this is one piece of the requested cleanups from rust-lang#117449

When we use `-> impl SomeTrait<_>` as a return type, we are both using the "infer return type suggestion" code path, and the infer opaque type code path within the same function. That can lead to confusing diagnostics, so silence all opaque type diagnostics in that case.

…ler-errors

Silence some follow-up errors [1/x]

this is one piece of the requested cleanups from rust-lang/rust#117449

When we use `-> impl SomeTrait<_>` as a return type, we are both using the "infer return type suggestion" code path, and the infer opaque type code path within the same function. That can lead to confusing diagnostics, so silence all opaque type diagnostics in that case.

…2, r=estebank

Silence some follow-up errors [2/x]

this is one piece of the requested cleanups from rust-lang#117449

the `type_of` query frequently uses astconv to convert a `hir::Ty` to a `ty::Ty`. This process is infallible, but may produce errors as it goes. All the error reporting sites that had access to the `ItemCtxt` are now tainting it, causing `type_of` to return a `ty::Error` instead of anything else.

…2, r=estebank

Silence some follow-up errors [2/x]

this is one piece of the requested cleanups from rust-lang#117449

the `type_of` query frequently uses astconv to convert a `hir::Ty` to a `ty::Ty`. This process is infallible, but may produce errors as it goes. All the error reporting sites that had access to the `ItemCtxt` are now tainting it, causing `type_of` to return a `ty::Error` instead of anything else.

Rollup merge of rust-lang#119813 - oli-obk:even_more_follow_up_errors2, r=estebank

Silence some follow-up errors [2/x]

this is one piece of the requested cleanups from rust-lang#117449

the `type_of` query frequently uses astconv to convert a `hir::Ty` to a `ty::Ty`. This process is infallible, but may produce errors as it goes. All the error reporting sites that had access to the `ItemCtxt` are now tainting it, causing `type_of` to return a `ty::Error` instead of anything else.

…3, r=compiler-errors

Silence some follow-up errors [3/x]

this is one piece of the requested cleanups from rust-lang#117449

Keep error types around, even in obligations.

These help silence follow-up errors, as we now figure out that some types (most notably inference variables) are equal to an error type.

But it also allows figuring out more types in the presence of errors, possibly causing more errors.

…3, r=compiler-errors

Silence some follow-up errors [3/x]

this is one piece of the requested cleanups from rust-lang#117449

Keep error types around, even in obligations.

These help silence follow-up errors, as we now figure out that some types (most notably inference variables) are equal to an error type.

But it also allows figuring out more types in the presence of errors, possibly causing more errors.

Rollup merge of rust-lang#119818 - oli-obk:even_more_follow_up_errors3, r=compiler-errors

Silence some follow-up errors [3/x]

this is one piece of the requested cleanups from rust-lang#117449

Keep error types around, even in obligations.

These help silence follow-up errors, as we now figure out that some types (most notably inference variables) are equal to an error type.

But it also allows figuring out more types in the presence of errors, possibly causing more errors.

…sper

replace `track_errors` usages with bubbling up `ErrorGuaranteed`

more of the same as rust-lang#117449 (removing `track_errors`)

Rollup merge of rust-lang#119869 - oli-obk:track_errors2, r=matthewjasper

replace `track_errors` usages with bubbling up `ErrorGuaranteed`

more of the same as rust-lang#117449 (removing `track_errors`)

replace `track_errors` usages with bubbling up `ErrorGuaranteed`

more of the same as rust-lang/rust#117449 (removing `track_errors`)

replace `track_errors` usages with bubbling up `ErrorGuaranteed`

more of the same as rust-lang/rust#117449 (removing `track_errors`)