Rid the AST & HIR pretty printer of cruft by fmease · Pull Request #119169

Rid the AST & HIR pretty printer of cruft by fmease · Pull Request #119169 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Dec 20, 2023

fmease added C-cleanup

Category: PRs that clean code up or issues documenting cleanup.

S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

labels

Dec 20, 2023

fmease added the A-pretty

Area: Pretty printing (including `-Z unpretty`)

label

Dec 20, 2023

fmease changed the title ~~Rid the AST & HIR pretty printers of syntactic cruft~~ Rid the AST & HIR pretty printers of cruft

Dec 20, 2023

fmease changed the title ~~Rid the AST & HIR pretty printers of cruft~~ Rid the AST & HIR pretty printer of cruft

Dec 20, 2023

fmease added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-blocked

Status: Blocked on something else such as an RFC or other implementation work.

labels

Dec 22, 2023

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Dec 22, 2023

bors added a commit to rust-lang-ci/rust that referenced this pull request

Dec 22, 2023

…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#117601 (Add support for hexagon-unknown-none-elf as target)
 - rust-lang#119169 (Rid the AST & HIR pretty printer of cruft)
 - rust-lang#119194 (Run fuchsia tests only on nightly)
 - rust-lang#119201 (tests: fix overaligned-constant to not over-specify getelementptr instr)
 - rust-lang#119215 (Emits error if has bound regions)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Dec 22, 2023

Rollup merge of rust-lang#119169 - fmease:pretty-yeet-syntactic-cruft, r=compiler-errors

Rid the AST & HIR pretty printer of cruft

Found while working on rust-lang#119163.

For `trait Trait: ?Sized {}` (semantically malformed), we currently output `trait Trait for ? Sized {}` (sic!) / `trait Trait for ? Sized { }` (sic!) if `-Zunpretty=expanded` / `-Zunpretty=hir` is passed.

`trait Tr for Sized? {}` (rust-lang#15521) and later also `trait Tr for ?Sized {}` (I guess, rust-lang#20194) is former Rust syntax. Hence I'm removing these outdated branches.

~~This will conflict with rust-lang#119163, therefore marking this PR as blocked.~~ Rebased

fmease deleted the pretty-yeet-syntactic-cruft branch

December 22, 2023 20:36