remove duplicate test by RalfJung · Pull Request #119628 · rust-lang/rust
rustbot
added
S-waiting-on-review
labels
Jan 5, 2024
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Jan 6, 2024compiler-errors added a commit to compiler-errors/rust that referenced this pull request
Jan 6, 2024…r-errors remove duplicate test This was added in rust-lang@ace6fc3 where overflowing-rsh-6 differed from overflowing-rsh-5 in a feature gate, but the feature has since been stabilized, making the tests 100% identical. Most of these tests in numbers-arithmetic could be put into one file rather than having so many files that all test the same lint... but it doesn't seem worth the effort. After rust-lang#119432 we might be able to remove most of them entirely as they will be covered by the new tests added there.
This was referenced
Jan 6, 2024bors added a commit to rust-lang-ci/rust that referenced this pull request
Jan 6, 2024…mpiler-errors Rollup of 9 pull requests Successful merges: - rust-lang#119208 (coverage: Hoist some complex code out of the main span refinement loop) - rust-lang#119216 (Use diagnostic namespace in stdlib) - rust-lang#119414 (bootstrap: Move -Clto= setting from Rustc::run to rustc_cargo) - rust-lang#119420 (Handle ForeignItem as TAIT scope.) - rust-lang#119468 (rustdoc-search: tighter encoding for f index) - rust-lang#119628 (remove duplicate test) - rust-lang#119638 (fix cyle error when suggesting to use associated function instead of constructor) - rust-lang#119640 (library: Fix warnings in rtstartup) - rust-lang#119642 (library: Fix a symlink test failing on Windows) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
Jan 6, 2024Rollup merge of rust-lang#119628 - RalfJung:duplicate-test, r=compiler-errors remove duplicate test This was added in rust-lang@ace6fc3 where overflowing-rsh-6 differed from overflowing-rsh-5 in a feature gate, but the feature has since been stabilized, making the tests 100% identical. Most of these tests in numbers-arithmetic could be put into one file rather than having so many files that all test the same lint... but it doesn't seem worth the effort. After rust-lang#119432 we might be able to remove most of them entirely as they will be covered by the new tests added there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters