Avoid ICEs in trait names without `dyn` by estebank · Pull Request #119752

Avoid ICEs in trait names without `dyn` by estebank · Pull Request #119752 · rust-lang/rust

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Jan 8, 2024

estebank changed the title ~~Avoid ICE: Check diagnostic is error before downgrading~~ Avoid ICEs in trait names without dyn

Jan 10, 2024

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Jan 19, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 20, 2024

Rollup merge of rust-lang#119752 - estebank:ice-ice, r=fmease

Avoid ICEs in trait names without `dyn`

Check diagnostic is error before downgrading. Fix rust-lang#119633.

 Account for traits using self-trait by name without `dyn`. Fix rust-lang#119652.

This was referenced

Jan 20, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 22, 2024

…-errors

`maybe_lint_impl_trait`: separate `is_downgradable` from `is_object_safe`

rust-lang#119752 leveraged and overloaded `is_object_safe` to prevent an ICE, but accurate object safety information is needed for precise suggestions. This separates out `is_downgradable`, used for the ICE prevention, and `is_object_safe`, which returns to its original meaning.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 22, 2024

…-errors

`maybe_lint_impl_trait`: separate `is_downgradable` from `is_object_safe`

rust-lang#119752 leveraged and overloaded `is_object_safe` to prevent an ICE, but accurate object safety information is needed for precise suggestions. This separates out `is_downgradable`, used for the ICE prevention, and `is_object_safe`, which returns to its original meaning.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Jan 22, 2024

…-errors

`maybe_lint_impl_trait`: separate `is_downgradable` from `is_object_safe`

rust-lang#119752 leveraged and overloaded `is_object_safe` to prevent an ICE, but accurate object safety information is needed for precise suggestions. This separates out `is_downgradable`, used for the ICE prevention, and `is_object_safe`, which returns to its original meaning.

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Jan 22, 2024

Rollup merge of rust-lang#120164 - trevyn:is_downgradable, r=compiler-errors

`maybe_lint_impl_trait`: separate `is_downgradable` from `is_object_safe`

rust-lang#119752 leveraged and overloaded `is_object_safe` to prevent an ICE, but accurate object safety information is needed for precise suggestions. This separates out `is_downgradable`, used for the ICE prevention, and `is_object_safe`, which returns to its original meaning.