Make `NonZero` constructors generic. by reitermarkus · Pull Request #120521 · rust-lang/rust

Make `NonZero` constructors generic. by reitermarkus · Pull Request #120521 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the library team, which will review and decide on the PR/issue.

labels

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

This was referenced

Feb 1, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? `@dtolnay`

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? ``@dtolnay``

bors added a commit to rust-lang-ci/rust that referenced this pull request

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

…ructors, r=dtolnay,oli-obk

Make `NonZero` constructors generic.

This makes `NonZero` constructors generic, so that `NonZero::new` can be used without turbofish syntax.

Tracking issue: rust-lang#120257

~~I cannot figure out how to make this work with `const` traits. Not sure if I'm using it wrong or whether there's a bug:~~

```rust
101 |         if n == T::ZERO {
    |            ^^^^^^^^^^^^ expected `host`, found `true`
    |
    = note: expected constant `host`
               found constant `true`
```

r? ```@dtolnay```

This was referenced

Feb 8, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

oli-obk added a commit to oli-obk/rust that referenced this pull request

oli-obk added a commit to oli-obk/rust that referenced this pull request

oli-obk added a commit to oli-obk/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

bors added a commit to rust-lang-ci/rust that referenced this pull request

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request

RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request