Stop bailing out from compilation just because there were incoherent traits by oli-obk · Pull Request #120558 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Feb 1, 2024

oli-obk

Noratrieb

estebank

estebank

lcnr

estebank

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Feb 2, 2024

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Feb 2, 2024

This was referenced

Feb 8, 2024

@oli-obk oli-obk deleted the missing_impl_item_ice branch

February 8, 2024 09:16

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 8, 2024
…l, r=<try>

Use `ensure` when the result of the query is not needed beyond its `Result`ness

while I would like to just remove the `tcx` methods for ensure-only queries, that is hard to do without another query annotation or by turning the `define_callbacks` macro into a proc macro to get more control

should fix perf regression of rust-lang#120558

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 9, 2024
A trait's local impls are trivially coherent if there are no impls.

This avoids creating a dependency edge on the hir or the specialization graph

This may resolve part of the performance issue of rust-lang#120558

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 9, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 9, 2024
Avoid accessing the HIR in the happy path of `coherent_trait`

This may resolve part of the performance issue of rust-lang#120558

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 10, 2024
…l, r=davidtwco

Use `ensure` when the result of the query is not needed beyond its `Result`ness

while I would like to just remove the `tcx` methods for ensure-only queries, that is hard to do without another query annotation or by turning the `define_callbacks` macro into a proc macro to get more control

should fix perf regression of rust-lang#120558

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request

Feb 11, 2024
…dtwco

Use `ensure` when the result of the query is not needed beyond its `Result`ness

while I would like to just remove the `tcx` methods for ensure-only queries, that is hard to do without another query annotation or by turning the `define_callbacks` macro into a proc macro to get more control

should fix perf regression of rust-lang/rust#120558

bors added a commit to rust-lang-ci/rust that referenced this pull request

Feb 12, 2024
A trait's local impls are trivially coherent if there are no impls.

This avoids creating a dependency edge on the hir or the specialization graph

This may resolve part of the performance issue of rust-lang#120558

RalfJung pushed a commit to RalfJung/miri that referenced this pull request

Feb 12, 2024
A trait's local impls are trivially coherent if there are no impls.

This avoids creating a dependency edge on the hir or the specialization graph

This may resolve part of the performance issue of rust-lang/rust#120558

lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request

Apr 7, 2024
A trait's local impls are trivially coherent if there are no impls.

This avoids creating a dependency edge on the hir or the specialization graph

This may resolve part of the performance issue of rust-lang/rust#120558

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 9, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 17, 2024

RalfJung pushed a commit to RalfJung/miri that referenced this pull request

Apr 17, 2024
Silence some follow-up errors on trait impls in case the trait has conflicting or otherwise incoherent impls

fixes #123292

Also removes a bunch of extra diagnostics that were introduced in rust-lang/rust#121154 and rust-lang/rust#120558

RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request

Apr 27, 2024
A trait's local impls are trivially coherent if there are no impls.

This avoids creating a dependency edge on the hir or the specialization graph

This may resolve part of the performance issue of rust-lang/rust#120558