Stop bailing out from compilation just because there were incoherent traits by oli-obk · Pull Request #120558 · rust-lang/rust
rustbot
added
S-waiting-on-review
labels
Feb 1, 2024
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
Feb 2, 2024
bors
added
S-waiting-on-author
and removed S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.labels
Feb 2, 2024This was referenced
Feb 8, 2024
oli-obk
deleted the
missing_impl_item_ice
branch
bors added a commit to rust-lang-ci/rust that referenced this pull request
Feb 8, 2024…l, r=<try> Use `ensure` when the result of the query is not needed beyond its `Result`ness while I would like to just remove the `tcx` methods for ensure-only queries, that is hard to do without another query annotation or by turning the `define_callbacks` macro into a proc macro to get more control should fix perf regression of rust-lang#120558
bors added a commit to rust-lang-ci/rust that referenced this pull request
Feb 9, 2024A trait's local impls are trivially coherent if there are no impls. This avoids creating a dependency edge on the hir or the specialization graph This may resolve part of the performance issue of rust-lang#120558
bors added a commit to rust-lang-ci/rust that referenced this pull request
Feb 9, 2024Avoid accessing the HIR in the happy path of `coherent_trait` This may resolve part of the performance issue of rust-lang#120558
bors added a commit to rust-lang-ci/rust that referenced this pull request
Feb 10, 2024…l, r=davidtwco Use `ensure` when the result of the query is not needed beyond its `Result`ness while I would like to just remove the `tcx` methods for ensure-only queries, that is hard to do without another query annotation or by turning the `define_callbacks` macro into a proc macro to get more control should fix perf regression of rust-lang#120558
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
Feb 11, 2024…dtwco Use `ensure` when the result of the query is not needed beyond its `Result`ness while I would like to just remove the `tcx` methods for ensure-only queries, that is hard to do without another query annotation or by turning the `define_callbacks` macro into a proc macro to get more control should fix perf regression of rust-lang/rust#120558
bors added a commit to rust-lang-ci/rust that referenced this pull request
Feb 12, 2024A trait's local impls are trivially coherent if there are no impls. This avoids creating a dependency edge on the hir or the specialization graph This may resolve part of the performance issue of rust-lang#120558
RalfJung pushed a commit to RalfJung/miri that referenced this pull request
Feb 12, 2024A trait's local impls are trivially coherent if there are no impls. This avoids creating a dependency edge on the hir or the specialization graph This may resolve part of the performance issue of rust-lang/rust#120558
lnicola pushed a commit to lnicola/rust-analyzer that referenced this pull request
Apr 7, 2024A trait's local impls are trivially coherent if there are no impls. This avoids creating a dependency edge on the hir or the specialization graph This may resolve part of the performance issue of rust-lang/rust#120558
RalfJung pushed a commit to RalfJung/miri that referenced this pull request
Apr 17, 2024Silence some follow-up errors on trait impls in case the trait has conflicting or otherwise incoherent impls fixes #123292 Also removes a bunch of extra diagnostics that were introduced in rust-lang/rust#121154 and rust-lang/rust#120558
RalfJung pushed a commit to RalfJung/rust-analyzer that referenced this pull request
Apr 27, 2024A trait's local impls are trivially coherent if there are no impls. This avoids creating a dependency edge on the hir or the specialization graph This may resolve part of the performance issue of rust-lang/rust#120558
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters