various clippy fixes by onur-ozkan · Pull Request #121543

various clippy fixes by onur-ozkan · Pull Request #121543 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Feb 24, 2024

onur-ozkan changed the title ~~reorder clippy rules to their original order before passing them~~ various clippy fixes

Feb 24, 2024

This was referenced

Feb 24, 2024

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Mar 14, 2024

We need to keep the order of the given clippy lint rules before passing them.
Since clap doesn't offer any useful interface for this purpose out of the box,
we have to handle it manually.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Previously, when passing lint rules manually using `x clippy ..`, ignored lints would
override manual ones. This change corrects the order by passing ignored lints after the
manual ones.

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Signed-off-by: onur-ozkan <work@onurozkan.dev>

Signed-off-by: onur-ozkan <work@onurozkan.dev>

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Mar 19, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 20, 2024

…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#121543 (various clippy fixes)
 - rust-lang#122540 (Do not use `?`-induced skewing of type inference in the compiler)
 - rust-lang#122730 (Expose `ucred::peer_cred` on QNX targets to enable dist builds)
 - rust-lang#122732 (Remove redundant coroutine captures note)
 - rust-lang#122739 (Add "put" as a confusable for insert on hash map/set)
 - rust-lang#122748 (Reduce `pub` usage in `rustc_session`.)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 20, 2024

Rollup merge of rust-lang#121543 - onur-ozkan:clippy-args, r=oli-obk

various clippy fixes

We need to keep the order of the given clippy lint rules before passing them.
Since clap doesn't offer any useful interface for this purpose out of the box,
we have to handle it manually.

Additionally, this PR makes `-D` rules work as expected. Previously, lint rules were limited to `-W`. By enabling `-D`, clippy began to complain numerous lines in the tree, all of which have been resolved in this PR as well.

Fixes rust-lang#121481
cc `@matthiaskrgr`