Replace libLLVM symlink with linker script by nikic · Pull Request #121967

Replace libLLVM symlink with linker script by nikic · Pull Request #121967 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-bootstrap

Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

labels

Mar 4, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2024

Replace libLLVM symlink with linker script

It turns out that the libLLVM-N.so -> libLLVM.so.N.1 symlink is also needed when projects like miri link against librustc_driver.so. As such, we have to distribute it in real rustup components like rustc-dev, rather than only for download-ci-llvm.

To avoid actually distributing symlinks (which are not supported or not fully supported by the rustup infrastructure) replace it with a linker script that does the same thing instead.

Fixes rust-lang#121889.

r? `@cuviper`

It turns out that the libLLVM-N.so -> libLLVM.so.N.1 symlink is
also needed when projects like miri link against librustc_driver.so.
As such, we have to distribute it in real rustup components like
rustc-dev, rather than only for download-ci-llvm.

To avoid actually distributing symlinks (which are not supported
or not fully supported by the rustup infrastructure) replace it
with a linker script that does the same thing instead.

bors added a commit to rust-lang-ci/rust that referenced this pull request

Mar 4, 2024

Replace libLLVM symlink with linker script

It turns out that the libLLVM-N.so -> libLLVM.so.N.1 symlink is also needed when projects like miri link against librustc_driver.so. As such, we have to distribute it in real rustup components like rustc-dev, rather than only for download-ci-llvm.

To avoid actually distributing symlinks (which are not supported or not fully supported by the rustup infrastructure) replace it with a linker script that does the same thing instead.

Fixes rust-lang#121889.

r? `@cuviper`

bors added the S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

label

Mar 6, 2024

bors mentioned this pull request

Mar 6, 2024

This was referenced

Mar 7, 2024

lqd mentioned this pull request

Mar 7, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Mar 7, 2024

…rk-Simulacrum

Include all library files in artifact summary on CI

It's not worth it to maintain any custom logic here. Just print all files in the `lib` directory, this should be forward compatible.

This fixes rust-lang#121866, based on rust-lang#121967.

r? `@Mark-Simulacrum`

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Mar 7, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 8, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Mar 8, 2024

Rollup merge of rust-lang#122136 - Kobzol:opt-dist-lookup-logic, r=Mark-Simulacrum

Include all library files in artifact summary on CI

It's not worth it to maintain any custom logic here. Just print all files in the `lib` directory, this should be forward compatible.

This fixes rust-lang#121866, based on rust-lang#121967.

r? `@Mark-Simulacrum`