Correctly change type when adding adjustments on top of `NeverToAny` by WaffleLapkin · Pull Request #123571

Correctly change type when adding adjustments on top of `NeverToAny` by WaffleLapkin · Pull Request #123571 · rust-lang/rust

WaffleLapkin changed the title ~~Correctly change type when adding adjustments on top of NeverToAny~~ Correctly change type when adding adjustments on top of NeverToAny

Apr 6, 2024

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

Apr 6, 2024

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

Apr 18, 2024

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Apr 18, 2024

…, r=compiler-errors

Correctly change type when adding adjustments on top of `NeverToAny`

I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`.

I rediscovered the issue when looking at rust-lang#123482's crater run.

r? compiler-errors
Fixes rust-lang#120600

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request

Apr 18, 2024

…, r=compiler-errors

Correctly change type when adding adjustments on top of `NeverToAny`

I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`.

I rediscovered the issue when looking at rust-lang#123482's crater run.

r? compiler-errors
Fixes rust-lang#120600

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

Apr 18, 2024

…, r=compiler-errors

Correctly change type when adding adjustments on top of `NeverToAny`

I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`.

I rediscovered the issue when looking at rust-lang#123482's crater run.

r? compiler-errors
Fixes rust-lang#120600

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 18, 2024

…kingjubilee

Rollup of 6 pull requests

Successful merges:

 - rust-lang#117919 (Introduce perma-unstable `wasm-c-abi` flag)
 - rust-lang#123571 (Correctly change type when adding adjustments on top of `NeverToAny`)
 - rust-lang#123752 (Properly handle emojis as literal prefix in macros)
 - rust-lang#123980 ( Add an opt-in to store incoming edges in `VecGraph` + misc)
 - rust-lang#124110 (Fix negating `f16` and `f128` constants)
 - rust-lang#124116 (when suggesting RUST_BACKTRACE=1, add a special note for Miri's env var isolation)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

Apr 19, 2024

(this currently produces malformed mir: we call `eq` with first argument not
being a reference)

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

Apr 19, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

Apr 19, 2024

…, r=compiler-errors

Correctly change type when adding adjustments on top of `NeverToAny`

I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`.

I rediscovered the issue when looking at rust-lang#123482's crater run.

r? compiler-errors
Fixes rust-lang#120600

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 19, 2024

…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#123571 (Correctly change type when adding adjustments on top of `NeverToAny`)
 - rust-lang#123729 (run-make: refactor out command wrappers for `clang` and `llvm-readobj`)
 - rust-lang#124149 (rustdoc-search: fix description on aliases in results)
 - rust-lang#124155 (bootstrap: don't use rayon for sysinfo)

r? `@ghost`
`@rustbot` modify labels: rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request

Apr 19, 2024

…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123571 (Correctly change type when adding adjustments on top of `NeverToAny`)
 - rust-lang#123729 (run-make: refactor out command wrappers for `clang` and `llvm-readobj`)
 - rust-lang#124106 (Don't repeatedly duplicate TAIT lifetimes for each subsequently nested TAIT)
 - rust-lang#124149 (rustdoc-search: fix description on aliases in results)
 - rust-lang#124155 (bootstrap: don't use rayon for sysinfo)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Apr 19, 2024

Rollup merge of rust-lang#123571 - WaffleLapkin:properly-adjust-never, r=compiler-errors

Correctly change type when adding adjustments on top of `NeverToAny`

I'm concerned that the check only caught the problem with `fallback = !`, because at least MIR contained `<() as PartialEq>::eq(move _5, move _7)` where `_5: ()`.

I rediscovered the issue when looking at rust-lang#123482's crater run.

r? compiler-errors
Fixes rust-lang#120600