default_alloc_error_hook: explain difference to default __rdl_oom in alloc by RalfJung · Pull Request #124059

default_alloc_error_hook: explain difference to default __rdl_oom in alloc by RalfJung · Pull Request #124059 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-libs

Relevant to the library team, which will review and decide on the PR/issue.

labels

Apr 17, 2024

RalfJung changed the title ~~default_alloc_error_hook: call the default hook for alloc instead of duplicating it~~ default_alloc_error_hook: explain difference to default __rdl_oom in alloc

Apr 17, 2024

bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 3, 2024

workingjubilee added a commit to workingjubilee/rustc that referenced this pull request

May 3, 2024

… r=workingjubilee

default_alloc_error_hook: explain difference to default __rdl_oom in alloc

Though I'm not sure if that is really the reason that this code is duplicated. On no_std it may already be possible to call user-defined code on allocation failure.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 3, 2024

… r=workingjubilee

default_alloc_error_hook: explain difference to default __rdl_oom in alloc

Though I'm not sure if that is really the reason that this code is duplicated. On no_std it may already be possible to call user-defined code on allocation failure.

This was referenced

May 3, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 3, 2024

…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#122492 (Implement ptr_as_ref_unchecked)
 - rust-lang#123815 (Fix cannot usage in time.rs)
 - rust-lang#124059 (default_alloc_error_hook: explain difference to default __rdl_oom in alloc)
 - rust-lang#124510 (Add raw identifier in a typo suggestion)
 - rust-lang#124555 (coverage: Clean up creation of MC/DC condition bitmaps)
 - rust-lang#124593 (Describe and use CStr literals in CStr and CString docs)
 - rust-lang#124630 (CI: remove `env-x86_64-apple-tests` YAML anchor)

r? `@ghost`
`@rustbot` modify labels: rollup

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 3, 2024

Rollup merge of rust-lang#124059 - RalfJung:default_alloc_error_hook, r=workingjubilee

default_alloc_error_hook: explain difference to default __rdl_oom in alloc

Though I'm not sure if that is really the reason that this code is duplicated. On no_std it may already be possible to call user-defined code on allocation failure.

RalfJung deleted the default_alloc_error_hook branch

May 4, 2024 06:38