Home Original page

Eliminate some `FIXME(lcnr)` comments by nnethercote · Pull Request #124918 · rust-lang/rust

@rustbot rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

T-compiler

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

May 9, 2024

mcol

I tried simplifying `RegionCtxt`, which led me to finding that the
fields are printed in `sccs_info`.
The comment mentions that `ReBound` and `ReVar` aren't expected here.
Experimentation with the full test suite indicates this is true, and
that `ReErased` also doesn't occur. So the commit introduces `bug!` for
those cases. (If any of them show up later on, at least we'll have a
test case.)

The commit also remove the first sentence in the comment.
`RePlaceholder` is now handled in the match arm above this comment and
nothing is printed for it, so that sentence is just wrong. Furthermore,
issue rust-lang#13998 was closed some time ago.

lcnr

The type name has changed.

@nnethercote 

The use of `Binder` was removed in the recent rust-lang#123900, but the comment
wasn't removed at the same time.
Thus eliminating a `FIXME` comment.

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

May 10, 2024

@bors bors added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

labels

May 10, 2024

@bors bors added S-waiting-on-bors

Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

and removed S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

labels

May 10, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 10, 2024 
Eliminate some `FIXME(lcnr)` comments

In some cases this involved changing code. In some cases the comment was able to removed or replaced.

r? `@lcnr`

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 10, 2024

bors added a commit to rust-lang-ci/rust that referenced this pull request

May 10, 2024

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 10, 2024 
Rollup merge of rust-lang#124918 - nnethercote:FIXME-lcnr, r=lcnr

Eliminate some `FIXME(lcnr)` comments

In some cases this involved changing code. In some cases the comment was able to removed or replaced.

r? ``@lcnr``

nnethercote added a commit to nnethercote/rust that referenced this pull request

May 12, 2024 
PR rust-lang#124918 made this path abort. The added test, from fuzzing,
identified that it is reachable.

flip1995 pushed a commit to flip1995/rust that referenced this pull request

May 17, 2024

nnethercote added a commit to nnethercote/rust that referenced this pull request

May 23, 2024 
PR rust-lang#124918 made this path abort. The added test, from fuzzing,
identified that it is reachable.

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request

May 23, 2024 
…-errors

Handle `ReVar` in `note_and_explain_region`

PR rust-lang#124918 made this path abort. The added test, from fuzzing, identified that it is reachable.

r? `@lcnr`

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

May 23, 2024 
Rollup merge of rust-lang#125054 - nnethercote:fix-124973, r=compiler-errors

Handle `ReVar` in `note_and_explain_region`

PR rust-lang#124918 made this path abort. The added test, from fuzzing, identified that it is reachable.

r? `@lcnr`