Don't call `env::set_var` in `rustc_driver::install_ice_hook` by tbu- · Pull Request #125063 · rust-lang/rust
rustbot
added
S-waiting-on-review
labels
May 13, 2024
tbu-
mentioned this pull request
bors
added
S-waiting-on-bors
and removed S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.labels
May 13, 2024fmease added a commit to fmease/rust that referenced this pull request
May 13, 2024matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request
May 13, 2024bors added a commit to rust-lang-ci/rust that referenced this pull request
May 13, 2024…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119515 (style-guide: Format single associated type `where` clauses on the same line) - rust-lang#119959 ([meta] Clarify prioritization alert) - rust-lang#123817 (Stabilize `seek_seek_relative`) - rust-lang#124532 (elaborate obligations in coherence) - rust-lang#125063 (Don't call `env::set_var` in `rustc_driver::install_ice_hook`) r? `@ghost` `@rustbot` modify labels: rollup
bors added a commit to rust-lang-ci/rust that referenced this pull request
May 13, 2024…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119515 (style-guide: Format single associated type `where` clauses on the same line) - rust-lang#119959 ([meta] Clarify prioritization alert) - rust-lang#123817 (Stabilize `seek_seek_relative`) - rust-lang#125063 (Don't call `env::set_var` in `rustc_driver::install_ice_hook`) - rust-lang#125071 (Migrate rustdoc target spec json path) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
May 13, 2024Rollup merge of rust-lang#125063 - tbu-:pr_set_ice_hook_env, r=michaelwoerister Don't call `env::set_var` in `rustc_driver::install_ice_hook` Modifying an environment variable would make the function unsafe to call.
fmease added a commit to fmease/rust that referenced this pull request
May 22, 2024…pture, r=nnethercote Use Backtrace::force_capture instead of Backtrace::capture in rustc_log After rust-lang#125063, the compiler and custom drivers won't automatically set the RUST_BACKTRACE environment variable anymore, so we have to call `Backtrace::force_capture` instead of `Backtrace::capture` to unconditionally capture a backtrace. rustc_log handles enabling backtraces via env vars itself, so we don't want RUST_BACKTRACE to make a difference.
fmease added a commit to fmease/rust that referenced this pull request
May 22, 2024…pture, r=nnethercote Use Backtrace::force_capture instead of Backtrace::capture in rustc_log After rust-lang#125063, the compiler and custom drivers won't automatically set the RUST_BACKTRACE environment variable anymore, so we have to call `Backtrace::force_capture` instead of `Backtrace::capture` to unconditionally capture a backtrace. rustc_log handles enabling backtraces via env vars itself, so we don't want RUST_BACKTRACE to make a difference.
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request
May 22, 2024Rollup merge of rust-lang#125355 - michaelwoerister:rust_log_force_capture, r=nnethercote Use Backtrace::force_capture instead of Backtrace::capture in rustc_log After rust-lang#125063, the compiler and custom drivers won't automatically set the RUST_BACKTRACE environment variable anymore, so we have to call `Backtrace::force_capture` instead of `Backtrace::capture` to unconditionally capture a backtrace. rustc_log handles enabling backtraces via env vars itself, so we don't want RUST_BACKTRACE to make a difference.
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request
May 23, 2024…nnethercote Use Backtrace::force_capture instead of Backtrace::capture in rustc_log After rust-lang/rust#125063, the compiler and custom drivers won't automatically set the RUST_BACKTRACE environment variable anymore, so we have to call `Backtrace::force_capture` instead of `Backtrace::capture` to unconditionally capture a backtrace. rustc_log handles enabling backtraces via env vars itself, so we don't want RUST_BACKTRACE to make a difference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters