Emit specific message for time<=0.3.35 by estebank · Pull Request #129343 · rust-lang/rust

Emit specific message for time<=0.3.35 by estebank · Pull Request #129343 · rust-lang/rust

rustbot added S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

Relevant to the compiler team, which will review and decide on the PR/issue.

labels

rustbot added S-waiting-on-author

Status: This is awaiting some action (such as code changes or more information) from the author.

and removed S-waiting-on-review

Status: Awaiting review from the assignee but also interested parties.

labels

rust-timer added a commit to rust-lang-ci/rust that referenced this pull request

Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu

Emit specific message for time<=0.3.35

```
error[E0282]: type annotations needed for `Box<_>`
  --> /home/gh-estebank/.cargo/registry/src/index.crates.io-6f17d22bba15001f/time-0.3.34/src/format_description/parse/mod.rs:83:9
   |
83 |     let items = format_items
   |         ^^^^^
...
86 |     Ok(items.into())
   |              ---- type must be known at this point
   |
   = note: this is an inference error on `time` caused by a change in Rust 1.80.0; update `time` to version `>=0.3.36`
```

Partially mitigate the fallout from rust-lang#127343. Although the biggest benefit of this would have been if we had had this in 1.80 before it became stable, the long-tail of that change will be felt for a *long* time, so better late than never.

We can also emit an even more targeted error instead of this inference failure.

bors added a commit to rust-lang-ci/rust that referenced this pull request

[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper

bors added a commit to rust-lang-ci/rust that referenced this pull request

[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper

bors added a commit to rust-lang-ci/rust that referenced this pull request

[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper

bors added a commit to rust-lang-ci/rust that referenced this pull request

[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper

bors added a commit to rust-lang-ci/rust that referenced this pull request

[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper

bors added a commit to rust-lang-ci/rust that referenced this pull request

[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper

bors added a commit to rust-lang-ci/rust that referenced this pull request

[beta] backports

- Emit specific message for `time<0.3.35` inference failure rust-lang#129343
- Use a reduced recursion limit in the MIR inliner's cycle breaker rust-lang#129714
- rustdoc: do not run doctests with invalid langstrings rust-lang#128838

r? cuviper

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Revert "Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu"

This reverts commit 26f75a6, reversing
changes made to 2572e0e.

Imports are modified to fix merge conflicts and remove unused ones.

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Revert "Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu"

This reverts commit 26f75a6, reversing
changes made to 2572e0e.

Imports are modified to fix merge conflicts and remove unused ones.

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Revert "Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu"

This reverts commit 26f75a6, reversing
changes made to 2572e0e.

Imports are modified to fix merge conflicts and remove unused ones.

jieyouxu added a commit to jieyouxu/rust that referenced this pull request

Manually revert rust-lang#129343 `time` diagnostics, which is a temporary
diagnostic to mitigate inference breakage fallout.

emilyalbini pushed a commit to emilyalbini/rust that referenced this pull request

Revert "Rollup merge of rust-lang#129343 - estebank:time-version, r=jieyouxu"

This reverts commit 26f75a6, reversing
changes made to 2572e0e.

Imports are modified to fix merge conflicts and remove unused ones.

jhpratt added a commit to jhpratt/rust that referenced this pull request

remove the explicit error for old `rental` versions

This was converted to a hard error 20 months ago (in rust-lang#125596). This seems like enough time for anyone still using it to notice, so remove the note entirely now.
In comparison, the explicit note for the more impactful `time` breakage was already removed after 6 months (rust-lang#129343).

Closes rust-lang#73933.
Closes rust-lang#83125.

r? @petrochenkov

jhpratt added a commit to jhpratt/rust that referenced this pull request

remove the explicit error for old `rental` versions

This was converted to a hard error 20 months ago (in rust-lang#125596). This seems like enough time for anyone still using it to notice, so remove the note entirely now.
In comparison, the explicit note for the more impactful `time` breakage was already removed after 6 months (rust-lang#129343).

Closes rust-lang#73933.
Closes rust-lang#83125.

r? @petrochenkov

jhpratt added a commit to jhpratt/rust that referenced this pull request

remove the explicit error for old `rental` versions

This was converted to a hard error 20 months ago (in rust-lang#125596). This seems like enough time for anyone still using it to notice, so remove the note entirely now.
In comparison, the explicit note for the more impactful `time` breakage was already removed after 6 months (rust-lang#129343).

Closes rust-lang#73933.
Closes rust-lang#83125.

r? @petrochenkov

Zalathar added a commit to Zalathar/rust that referenced this pull request

remove the explicit error for old `rental` versions

This was converted to a hard error 20 months ago (in rust-lang#125596). This seems like enough time for anyone still using it to notice, so remove the note entirely now.
In comparison, the explicit note for the more impactful `time` breakage was already removed after 6 months (rust-lang#129343).

Closes rust-lang#73933.
Closes rust-lang#83125.

r? @petrochenkov

rust-timer added a commit that referenced this pull request

Rollup merge of #152753 - cyrgani:remove-hack, r=petrochenkov

remove the explicit error for old `rental` versions

This was converted to a hard error 20 months ago (in #125596). This seems like enough time for anyone still using it to notice, so remove the note entirely now.
In comparison, the explicit note for the more impactful `time` breakage was already removed after 6 months (#129343).

Closes #73933.
Closes #83125.

r? @petrochenkov

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request